Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1354323002: Revert of Avoid CTFontCreateCopyWithAttributes. (Closed)

Created:
5 years, 3 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
erikchen, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Avoid CTFontCreateCopyWithAttributes. (patchset #4 id:60001 of https://codereview.chromium.org/1344213004/ ) Reason for revert: Causes issues with synthetic bold italic on all versions of OSX, with OSX10.10 resulting in many measurement related changes (this is expected though). fast/text/atsui-multiple-renderers.html fast/css/font-face-synthetic-bold-italic.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9__retina_/6168/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/4525/layout-test-results/results.html Original issue's description: > Avoid CTFontCreateCopyWithAttributes. > > It appears that CTFontCreateCopyWithAttributes and > CTFontCreateCopyWithSymbolicTraits share similar issues with the default > font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as > it will not work with webfonts. Since this is all low-level use, create the > CTFonts from the underlying CGFonts directly. > > BUG=chromium:524646 > > Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f TBR=erikchen@chromium.org,mtklein@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524646 Committed: https://skia.googlesource.com/skia/+/4de8c3a401eb3b5a5899f0bfbcc74556cd8f7bf9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -71 lines) Patch
M src/ports/SkFontHost_mac.cpp View 6 chunks +34 lines, -71 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
Created Revert of Avoid CTFontCreateCopyWithAttributes.
5 years, 3 months ago (2015-09-19 06:03:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354323002/1
5 years, 3 months ago (2015-09-19 06:03:19 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 06:03:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4de8c3a401eb3b5a5899f0bfbcc74556cd8f7bf9

Powered by Google App Engine
This is Rietveld 408576698