Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1354283002: Use QUIC for DRP if field trial group starts with Enabled (Closed)

Created:
5 years, 3 months ago by tbansal1
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton, sclittle
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use QUIC for DataReductionProxy if user belongs to field trial group that starts with "Enabled". Currently, QUIC is used if the field trial group is exactly "Enabled". This change allows us to have multiple Enabled groups (e.g., "Enabled", "Enabled2" etc.). BUG=533703 Committed: https://crrev.com/5cc3f0a27b1c73102bfeee73d6fe24e3400de633 Cr-Commit-Position: refs/heads/master@{#350061}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Minor changes #

Total comments: 2

Patch Set 3 : Removed extra check #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -24 lines) Patch
M chrome/browser/io_thread_unittest.cc View 1 2 3 1 chunk +39 lines, -11 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc View 1 2 3 2 chunks +34 lines, -12 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
tbansal1
PTAL. Thanks!
5 years, 3 months ago (2015-09-19 00:20:00 UTC) #2
sclittle
lgtm % nit https://codereview.chromium.org/1354283002/diff/1/chrome/browser/io_thread_unittest.cc File chrome/browser/io_thread_unittest.cc (right): https://codereview.chromium.org/1354283002/diff/1/chrome/browser/io_thread_unittest.cc#newcode184 chrome/browser/io_thread_unittest.cc:184: std::string(), false, nit: Could these be ...
5 years, 3 months ago (2015-09-19 00:45:21 UTC) #3
tbansal1
rch, PTAL at io_thread_unittest.cc. Thanks! https://codereview.chromium.org/1354283002/diff/1/chrome/browser/io_thread_unittest.cc File chrome/browser/io_thread_unittest.cc (right): https://codereview.chromium.org/1354283002/diff/1/chrome/browser/io_thread_unittest.cc#newcode184 chrome/browser/io_thread_unittest.cc:184: std::string(), false, On 2015/09/19 ...
5 years, 3 months ago (2015-09-21 16:55:53 UTC) #5
Ryan Hamilton
io_thread_unittests.cc: LGTM, mod one nit. https://codereview.chromium.org/1354283002/diff/40001/chrome/browser/io_thread_unittest.cc File chrome/browser/io_thread_unittest.cc (right): https://codereview.chromium.org/1354283002/diff/40001/chrome/browser/io_thread_unittest.cc#newcode212 chrome/browser/io_thread_unittest.cc:212: EXPECT_EQ(1024 * 1024, params.quic_socket_receive_buffer_size) ...
5 years, 3 months ago (2015-09-21 17:50:47 UTC) #7
tbansal1
Removed extra check. https://codereview.chromium.org/1354283002/diff/40001/chrome/browser/io_thread_unittest.cc File chrome/browser/io_thread_unittest.cc (right): https://codereview.chromium.org/1354283002/diff/40001/chrome/browser/io_thread_unittest.cc#newcode212 chrome/browser/io_thread_unittest.cc:212: EXPECT_EQ(1024 * 1024, params.quic_socket_receive_buffer_size) << i; ...
5 years, 3 months ago (2015-09-21 17:53:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354283002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354283002/200001
5 years, 3 months ago (2015-09-21 22:14:09 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:200001)
5 years, 3 months ago (2015-09-21 23:38:56 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 23:40:27 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5cc3f0a27b1c73102bfeee73d6fe24e3400de633
Cr-Commit-Position: refs/heads/master@{#350061}

Powered by Google App Engine
This is Rietveld 408576698