Use QUIC for DRP if field trial group starts with Enabled

chrome/browser/io_thread_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/test/mock_entropy_provider.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
@@ skipping 158 matching lines @@
   EXPECT_FALSE(params.quic_enable_non_blocking_io);
   EXPECT_FALSE(params.quic_disable_disk_cache);
   EXPECT_FALSE(params.quic_prefer_aes);
   EXPECT_FALSE(params.use_alternative_services);
   EXPECT_EQ(4, params.quic_max_number_of_lossy_connections);
   EXPECT_EQ(0.5f, params.quic_packet_loss_threshold);
   EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
 }
 
 TEST_F(IOThreadTest, EnableQuicFromQuicProxyFieldTrialGroup) {
-  base::FieldTrialList field_trial_list(new base::MockEntropyProvider());
-  base::FieldTrialList::CreateFieldTrial(
-      data_reduction_proxy::params::GetQuicFieldTrialName(), "Enabled");
+  const struct {
+    std::string field_trial_group_name;
+    bool expect_enable_quic;
+  } tests[] = {
+      {
+          std::string(), false,
+      },
+      {
+          "Enabled", true,
+      },
+      {
+          "EnabledControl", true,
+      },
+      {
+          "NotEnabled", false,
+      },
+      {
+          "Control", false,
+      },
+      {
+          "Disabled", false,
+      },
+  };
 
-  ConfigureQuicGlobals();
-  net::HttpNetworkSession::Params params;
-  InitializeNetworkSessionParams(&params);
-  EXPECT_FALSE(params.enable_quic);
-  EXPECT_TRUE(params.enable_quic_for_proxies);
-  EXPECT_TRUE(IOThread::ShouldEnableQuicForDataReductionProxy());
-  EXPECT_EQ(1024 * 1024, params.quic_socket_receive_buffer_size);
+  for (size_t i = 0; i < arraysize(tests); ++i) {
+    base::FieldTrialList field_trial_list(new base::MockEntropyProvider());
+    base::FieldTrialList::CreateFieldTrial(
+        data_reduction_proxy::params::GetQuicFieldTrialName(),
+        tests[i].field_trial_group_name);
+
+    ConfigureQuicGlobals();
+    net::HttpNetworkSession::Params params;
+    InitializeNetworkSessionParams(&params);
+    EXPECT_EQ(1024 * 1024, params.quic_socket_receive_buffer_size) << i;

[Ryan Hamilton, 2015/09/21 17:50:47]

It doesn't seem like you need to test this here, do you?

[tbansal1, 2015/09/21 17:53:15]

Removed.

+    EXPECT_FALSE(params.enable_quic) << i;
+    EXPECT_EQ(tests[i].expect_enable_quic, params.enable_quic_for_proxies) << i;
+    EXPECT_EQ(tests[i].expect_enable_quic,
+              IOThread::ShouldEnableQuicForDataReductionProxy())
+        << i;
+  }
 }
 
 TEST_F(IOThreadTest, EnableQuicFromCommandLine) {
   command_line_.AppendSwitch("enable-quic");
 
   ConfigureQuicGlobals();
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
   EXPECT_TRUE(params.enable_quic);
   EXPECT_TRUE(params.enable_quic_for_proxies);
@@ skipping 266 matching lines @@
   command_line_.AppendSwitch(switches::kEnableQuic);
   is_quic_allowed_by_policy_ = false;
   ConfigureQuicGlobals();
 
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
   EXPECT_FALSE(params.enable_quic);
 }
 
 }  // namespace test