Use a kMaxSafeInteger instead of Number.MAX_SAFE_INTEGER

Use a kMaxSafeInteger instead of Number.MAX_SAFE_INTEGER

Defines and uses a kMaxSafeInteger macro (which expands to the constant
2^53-1) instead of accessing Number.MAX_SAFE_INTEGER. This saves loading
the attribute from the Number object, which is slightly faster. This also
makes it clearer from reading the code that tha value being compared is
constant.

BUG=
LOG=N

Committed: https://crrev.com/3ece714df62df2c641ed15acee1736a49675add4
Cr-Commit-Position: refs/heads/master@{#30814}

[aperez, 2015-09-17 20:10:33]

aperez@igalia.com changed reviewers:
+ adamk@chromium.org, bmeurer@chromium.org, wingo@igalia.com

[aperez, 2015-09-17 20:11:43]

PTAL. This contains just the Number.MAX_SAFE_INTEGER → kMaxSafeInteger bit from
https://codereview.chromium.org/1348943002/

[adamk, 2015-09-17 21:07:08]

lgtm once you've removed the now-unnecessary GlobalNumber var in runtime.js

https://codereview.chromium.org/1353953002/diff/1/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/1353953002/diff/1/src/runtime.js#newcode36
src/runtime.js:36: var GlobalNumber = global.Number;
I don't think you need this import anymore.

[aperez, 2015-09-17 23:33:09]

Updated.

https://codereview.chromium.org/1353953002/diff/1/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/1353953002/diff/1/src/runtime.js#newcode36
src/runtime.js:36: var GlobalNumber = global.Number;
On 2015/09/17 21:07:08, adamk wrote:
> I don't think you need this import anymore.

Acknowledged.

[aperez, 2015-09-17 23:33:16]

The CQ bit was checked by aperez@igalia.com

[aperez, 2015-09-17 23:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1353953002/#ps20001
(title: "Zap unneccessary GlobalNumber in runtime.js")

[commit-bot: I haz the power, 2015-09-17 23:33:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353953002/20001

[commit-bot: I haz the power, 2015-09-17 23:59:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-18 00:00:10]

Patchset 2 (id:??) landed as
https://crrev.com/3ece714df62df2c641ed15acee1736a49675add4
Cr-Commit-Position: refs/heads/master@{#30814}