src/runtime.js - Issue 1353953002: Use a kMaxSafeInteger instead of Number.MAX_SAFE_INTEGER

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.js

Issue 1353953002: Use a kMaxSafeInteger instead of Number.MAX_SAFE_INTEGER (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Zap unneccessary GlobalNumber in runtime.js Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.js

diff --git a/src/runtime.js b/src/runtime.js

index 39939b16027f9447967becf4e3b374aafdb8fd21..a49a3bdfa991279df019c6d944cb6d3e2c08bf82 100644

--- a/src/runtime.js

+++ b/src/runtime.js

@@ -33,7 +33,6 @@ var harmony_tolength = false;

var GlobalArray = global.Array;

var GlobalBoolean = global.Boolean;

var GlobalString = global.String;

-var GlobalNumber = global.Number;

var isConcatSpreadableSymbol =

utils.ImportNow("is_concat_spreadable_symbol");

@@ -302,8 +301,7 @@ function ToInteger(x) {

function ToLength(arg) {

arg = ToInteger(arg);

if (arg < 0) return 0;

- return arg < GlobalNumber.MAX_SAFE_INTEGER ? arg

- : GlobalNumber.MAX_SAFE_INTEGER;

+ return arg < kMaxSafeInteger ? arg : kMaxSafeInteger;

}

« no previous file with comments | « src/macros.py ('k') | src/v8natives.js » ('j') | no next file with comments »