Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1353933002: NetworkPortalDetectorInterface class. (Closed)

Created:
5 years, 3 months ago by achuithb
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@portal_refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NetworkPortalDetectorInterface class. BUG=530485

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -206 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/net/delay_network_call.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.h View 1 2 3 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 1 2 3 2 chunks +32 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/network/portal_detector/network_portal_detector.h View 1 2 3 3 chunks +12 lines, -102 lines 0 comments Download
M chromeos/network/portal_detector/network_portal_detector.cc View 2 chunks +4 lines, -35 lines 0 comments Download
A + chromeos/network/portal_detector/network_portal_detector_interface.h View 1 2 3 5 chunks +14 lines, -44 lines 0 comments Download
A chromeos/network/portal_detector/network_portal_detector_interface.cc View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353933002/1
5 years, 3 months ago (2015-09-17 18:41:16 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 19:11:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353933002/20001
5 years, 3 months ago (2015-09-17 19:34:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 20:03:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353933002/40001
5 years, 3 months ago (2015-09-17 22:39:43 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 23:21:44 UTC) #12
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698