chrome/browser/chromeos/net/network_portal_notification_controller.cc - Issue 1353933002: NetworkPortalDetectorInterface class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.cc

Issue 1353933002: NetworkPortalDetectorInterface class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@portal_refactor

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/net/network_portal_notification_controller.cc

diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.cc b/chrome/browser/chromeos/net/network_portal_notification_controller.cc

index 57bb379475301ec98fc50a3dd8ef54fa38018a33..5bfff3cb703f410fa8266b556dfc67c090e9a464 100644

--- a/chrome/browser/chromeos/net/network_portal_notification_controller.cc

+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.cc

@@ -237,7 +237,7 @@ const char NetworkPortalNotificationController::kUserActionMetric[] =

"CaptivePortal.Notification.UserAction";

NetworkPortalNotificationController::NetworkPortalNotificationController(

- NetworkPortalDetector* network_portal_detector)

+ NetworkPortalDetectorInterface* network_portal_detector)

: network_portal_detector_(network_portal_detector), weak_factory_(this) {

if (NetworkHandler::IsInitialized()) { // NULL for unit tests.

NetworkHandler::Get()->network_state_handler()->AddObserver(this,

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_notification_controller.h ('k') | chromeos/chromeos.gyp » ('j') | no next file with comments »