Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 13538003: Add support for runtime flags for experimental blending to chromium (Closed)

Created:
7 years, 8 months ago by mihai.o.tica
Modified:
7 years, 8 months ago
Reviewers:
jamesr, RikC, eseidel
CC:
blink-reviews
Base URL:
http://src.chromium.org/blink/trunk/Source/
Visibility:
Public.

Description

Add support for runtime flags for experimental blending to chromium BUG=154769, 229220 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148489

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M WebKit/chromium/features.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
mihai.o.tica
Hi James, could you please review adding css blending under the experimental features flag please? ...
7 years, 8 months ago (2013-04-08 18:55:23 UTC) #1
jamesr
I don't know enough about ENABLE_CSS_COMPOSITING to know if this makes sense. Is there a ...
7 years, 8 months ago (2013-04-08 21:57:41 UTC) #2
mihai.o.tica
On 2013/04/08 21:57:41, jamesr wrote: > I don't know enough about ENABLE_CSS_COMPOSITING to know if ...
7 years, 8 months ago (2013-04-09 04:41:29 UTC) #3
jamesr
Could you file a blink bug to track this? Some parts will have to be ...
7 years, 8 months ago (2013-04-09 06:43:54 UTC) #4
mihai.o.tica
On 2013/04/09 06:43:54, jamesr wrote: > Could you file a blink bug to track this? ...
7 years, 8 months ago (2013-04-09 08:13:46 UTC) #5
mihai.o.tica
After a more detailed search, I've found the actual feature issue at: https://code.google.com/p/chromium/issues/detail?id=154769, please ignore ...
7 years, 8 months ago (2013-04-09 13:21:33 UTC) #6
jamesr
lgtm, although it'd be much better to simply eliminate the #ifs completely. Please do that ...
7 years, 8 months ago (2013-04-09 18:14:51 UTC) #7
jamesr
Sorry I'm still a little behind on the process. Can you schedule this feature for ...
7 years, 8 months ago (2013-04-09 19:33:10 UTC) #8
mihai.o.tica
I've updated the patch to point to the proper bugs, could you please give it ...
7 years, 8 months ago (2013-04-10 17:07:52 UTC) #9
RikC
On 2013/04/09 19:33:10, jamesr wrote: > Sorry I'm still a little behind on the process. ...
7 years, 8 months ago (2013-04-11 04:10:19 UTC) #10
mihai.o.tica
We've started the "intent to implement" thread and the conclusion was that this feature should ...
7 years, 8 months ago (2013-04-12 16:40:15 UTC) #11
jamesr
On 2013/04/12 16:40:15, mihai.o.tica wrote: > We've started the "intent to implement" thread and the ...
7 years, 8 months ago (2013-04-12 17:25:36 UTC) #12
RikC
> > Do you this overall change, which also includes the chromium part from > ...
7 years, 8 months ago (2013-04-12 17:31:55 UTC) #13
jamesr
On 2013/04/12 17:31:55, RikC wrote: > > > Do you this overall change, which also ...
7 years, 8 months ago (2013-04-12 17:41:27 UTC) #14
jamesr
Committed patchset #2 manually as r148489 (presubmit successful).
7 years, 8 months ago (2013-04-16 19:53:18 UTC) #15
jamesr
Reverted: https://src.chromium.org/viewvc/blink?revision=148519&view=revision since the new CSS property names are exposed to the web. You need ...
7 years, 8 months ago (2013-04-17 00:58:31 UTC) #16
RikC
On 2013/04/17 00:58:31, jamesr wrote: > Reverted: https://src.chromium.org/viewvc/blink?revision=148519&view=revision > > since the new CSS property ...
7 years, 8 months ago (2013-04-17 06:11:37 UTC) #17
eseidel
7 years, 8 months ago (2013-04-17 06:52:32 UTC) #18
Message was sent while issue was closed.
No. :)  I've posted a proposal for guarding CSS properties at runtime in that
bug.  I'll be working on making that proposal a reality next Monday if no one
else beats me to it.  Unfortunately I am away from my desk much of the rest of
the week.

Powered by Google App Engine
This is Rietveld 408576698