Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
12681024:
Enable CSS Blending support under the webkit experimental features chromium flag. (Closed)
|
Created:
7 years, 9 months ago by mihai.o.tica Modified:
7 years, 7 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, leviw_travelin_and_unemployed, abarth-chromium Base URL:
http://src.chromium.org/svn/trunk/src/ Visibility:
Public. |
DescriptionEnable CSS Blending support under the webkit experimental features chromium flag.
This is the second part of the webkit bug described here:
https://bugs.webkit.org/show_bug.cgi?id=113394
BUG=224314
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198142
Patch Set 1 #Patch Set 2 : Rebase patch #Patch Set 3 : Rebase, add correct email to the authors list #Messages
Total messages: 32 (0 generated)
On 2013/03/28 21:14:08, mihai.o.tica wrote: This looks reasonable. But I doubt I'm an OWNER of this code. I haven't committed to chromium proper in years. I recommend trying jamesr, tonyc, ojan, etc.
On 2013/03/28 21:17:50, Eric Seidel (Google) wrote: > On 2013/03/28 21:14:08, mihai.o.tica wrote: > > This looks reasonable. But I doubt I'm an OWNER of this code. I haven't > committed to chromium proper in years. I recommend trying jamesr, tonyc, ojan, > etc. Ok, thanks for the tip and sorry for the bother.
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Hey James, could you please have a look at this?
We seem to enable some things behind kEnableExperimentalWebKitFeatures here in the render process and some up in the browser process in web_contents_impl. What's the correct way to do this supposed to be? It's incredibly confusing having this spread out.
IMHO, we should pipe the experimental features flag into Blink as one bit and set all the runtime flags there.
It seems like grid layout, sticky positions and variables can be switched in both webkit_glue::WebPreferences and WebCore::Settings, which is a bit misleading. On the other hand, regions, exclusions and compositing can only be enabled in RuntimeEnabledFeatures, so I'm guessing this is probably the better way of adding the runtime flag for these features. Since this currently blocks a number of patches on CSS Blending, could you please have another look at this? Thanks!
On 2013/04/27 01:33:00, abarth wrote: > IMHO, we should pipe the experimental features flag into Blink as one bit and > set all the runtime flags there. Correct. I will be fixing this this week.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/1
Failed to apply patch for AUTHORS: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file AUTHORS Hunk #1 FAILED at 233. 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej Patch: AUTHORS Index: AUTHORS =================================================================== --- AUTHORS (revision 190930) +++ AUTHORS (working copy) @@ -233,3 +233,4 @@ Jun Jiang <jun.a.jiang@intel.com> Bobby Powers <bobbypowers@gmail.com> Patrick Riordan <patrickriordan177@gmail.com> +Mihai Tica <mitica@adobe.com>
Enable CSS Blending support under the webkit experimental features chromium flag. BUG=224314
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/16001
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/16001
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/16001
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/16001
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
Could any of you guys commit this CL manually, please?
It appears to be upset that the account which created this CL and the AUTHORS entry do not agree.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/37001
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
As it turns out, I need the LGTM of an OWNER for content/renderer/render_thread_impl.cc, James, could you please help me out with this? Thanks!
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/37001
Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihai.o.tica@gmail.com/12681024/37001
Message was sent while issue was closed.
Change committed as 198142 |
