Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event.html

Issue 1353653003: DevTools: cleanup timeline concise record details generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-uploading after blink repo merge Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event.html
index e824b27e03bebda21abf30891ae462f313d1ca37..820adc54cd60312c479b77c82dc7babc38bedb97 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event.html
@@ -26,6 +26,9 @@ function test()
function finish()
{
+ var recordTypes = WebInspector.TimelineModel.RecordType;
+ var typesToDump = new Set([recordTypes.ResourceSendRequest, recordTypes.ResourceReceiveResponse, recordTypes.ResourceReceivedData, recordTypes.ResourceFinish,
+ recordTypes.EventDispatch, recordTypes.FunctionCall]);
function dumpFormattedRecord(presentationRecord, prefix)
{
var record = presentationRecord.record();
@@ -37,8 +40,7 @@ function test()
var childPrefix = prefix;
// Here and below: pretend coalesced record are just not there, as coalescation is time dependent and, hence, not stable.
// Filter out InjectedScript function call because they happen out of sync.
- if (!presentationRecord.coalesced()
- && record.type() !== "GCEvent"
+ if (!presentationRecord.coalesced() && typesToDump.has(record.type())
&& (record.type() !== "FunctionCall" || record.traceEvent().args["data"].scriptName)) {
InspectorTest.addResult(prefix + record.type());
childPrefix = childPrefix + " ";

Powered by Google App Engine
This is Rietveld 408576698