content/child/background_sync/background_sync_provider.h - Issue 1353613002: [BackgroundSync] Clean up some style nits and unnecessary checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/background_sync/background_sync_provider.h

Issue 1353613002: [BackgroundSync] Clean up some style nits and unnecessary checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_service_impl.cc ('k') | content/child/background_sync/background_sync_provider_thread_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/background_sync/background_sync_provider.h

diff --git a/content/child/background_sync/background_sync_provider.h b/content/child/background_sync/background_sync_provider.h

index 768555dd7cf0208b3cb7476b6f4118756a07e39d..2668faa77e8bf39596e54f7b14d5beea47b2a9b5 100644

--- a/content/child/background_sync/background_sync_provider.h

+++ b/content/child/background_sync/background_sync_provider.h

@@ -34,29 +34,29 @@ class BackgroundSyncProvider : public blink::WebSyncProvider {

const blink::WebSyncRegistration* options,

blink::WebServiceWorkerRegistration* service_worker_registration,

bool requested_from_service_worker,

- blink::WebSyncRegistrationCallbacks* callbacks);

+ blink::WebSyncRegistrationCallbacks* callbacks) override;

// TODO(jkarlin) remove |tag| parameter.

void unregisterBackgroundSync(

blink::WebSyncRegistration::Periodicity periodicity,

int64_t handle_id,

const blink::WebString& tag,

blink::WebServiceWorkerRegistration* service_worker_registration,

- blink::WebSyncUnregistrationCallbacks* callbacks);

+ blink::WebSyncUnregistrationCallbacks* callbacks) override;

void getRegistration(

blink::WebSyncRegistration::Periodicity,

const blink::WebString& tag,

blink::WebServiceWorkerRegistration* service_worker_registration,

- blink::WebSyncRegistrationCallbacks* callbacks);

+ blink::WebSyncRegistrationCallbacks* callbacks) override;

void getRegistrations(

blink::WebSyncRegistration::Periodicity periodicity,

blink::WebServiceWorkerRegistration* service_worker_registration,

- blink::WebSyncGetRegistrationsCallbacks* callbacks);

+ blink::WebSyncGetRegistrationsCallbacks* callbacks) override;

void getPermissionStatus(

blink::WebSyncRegistration::Periodicity periodicity,

blink::WebServiceWorkerRegistration* service_worker_registration,

- blink::WebSyncGetPermissionStatusCallbacks* callbacks);

+ blink::WebSyncGetPermissionStatusCallbacks* callbacks) override;

// TODO(jkarlin): Rename to releaseRegistrationHandle.

- void releaseRegistration(int64_t handle_id);

+ void releaseRegistration(int64_t handle_id) override;

void DuplicateRegistrationHandle(

int handle_id,