Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: content/child/background_sync/background_sync_provider.h

Issue 1353613002: [BackgroundSync] Clean up some style nits and unnecessary checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_CHILD_BACKGROUND_SYNC_BACKGROUND_SYNC_PROVIDER_H_ 5 #ifndef CONTENT_CHILD_BACKGROUND_SYNC_BACKGROUND_SYNC_PROVIDER_H_
6 #define CONTENT_CHILD_BACKGROUND_SYNC_BACKGROUND_SYNC_PROVIDER_H_ 6 #define CONTENT_CHILD_BACKGROUND_SYNC_BACKGROUND_SYNC_PROVIDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 16 matching lines...) Expand all
27 27
28 ~BackgroundSyncProvider() override; 28 ~BackgroundSyncProvider() override;
29 29
30 // blink::WebSyncProvider implementation 30 // blink::WebSyncProvider implementation
31 // TODO(jkarlin) convert int64_t handle_id to int handle_id in all 31 // TODO(jkarlin) convert int64_t handle_id to int handle_id in all
32 // WebSyncProvider functions. 32 // WebSyncProvider functions.
33 void registerBackgroundSync( 33 void registerBackgroundSync(
34 const blink::WebSyncRegistration* options, 34 const blink::WebSyncRegistration* options,
35 blink::WebServiceWorkerRegistration* service_worker_registration, 35 blink::WebServiceWorkerRegistration* service_worker_registration,
36 bool requested_from_service_worker, 36 bool requested_from_service_worker,
37 blink::WebSyncRegistrationCallbacks* callbacks); 37 blink::WebSyncRegistrationCallbacks* callbacks) override;
38 // TODO(jkarlin) remove |tag| parameter. 38 // TODO(jkarlin) remove |tag| parameter.
39 void unregisterBackgroundSync( 39 void unregisterBackgroundSync(
40 blink::WebSyncRegistration::Periodicity periodicity, 40 blink::WebSyncRegistration::Periodicity periodicity,
41 int64_t handle_id, 41 int64_t handle_id,
42 const blink::WebString& tag, 42 const blink::WebString& tag,
43 blink::WebServiceWorkerRegistration* service_worker_registration, 43 blink::WebServiceWorkerRegistration* service_worker_registration,
44 blink::WebSyncUnregistrationCallbacks* callbacks); 44 blink::WebSyncUnregistrationCallbacks* callbacks) override;
45 void getRegistration( 45 void getRegistration(
46 blink::WebSyncRegistration::Periodicity, 46 blink::WebSyncRegistration::Periodicity,
47 const blink::WebString& tag, 47 const blink::WebString& tag,
48 blink::WebServiceWorkerRegistration* service_worker_registration, 48 blink::WebServiceWorkerRegistration* service_worker_registration,
49 blink::WebSyncRegistrationCallbacks* callbacks); 49 blink::WebSyncRegistrationCallbacks* callbacks) override;
50 void getRegistrations( 50 void getRegistrations(
51 blink::WebSyncRegistration::Periodicity periodicity, 51 blink::WebSyncRegistration::Periodicity periodicity,
52 blink::WebServiceWorkerRegistration* service_worker_registration, 52 blink::WebServiceWorkerRegistration* service_worker_registration,
53 blink::WebSyncGetRegistrationsCallbacks* callbacks); 53 blink::WebSyncGetRegistrationsCallbacks* callbacks) override;
54 void getPermissionStatus( 54 void getPermissionStatus(
55 blink::WebSyncRegistration::Periodicity periodicity, 55 blink::WebSyncRegistration::Periodicity periodicity,
56 blink::WebServiceWorkerRegistration* service_worker_registration, 56 blink::WebServiceWorkerRegistration* service_worker_registration,
57 blink::WebSyncGetPermissionStatusCallbacks* callbacks); 57 blink::WebSyncGetPermissionStatusCallbacks* callbacks) override;
58 // TODO(jkarlin): Rename to releaseRegistrationHandle. 58 // TODO(jkarlin): Rename to releaseRegistrationHandle.
59 void releaseRegistration(int64_t handle_id); 59 void releaseRegistration(int64_t handle_id) override;
60 60
61 void DuplicateRegistrationHandle( 61 void DuplicateRegistrationHandle(
62 int handle_id, 62 int handle_id,
63 const BackgroundSyncService::DuplicateRegistrationHandleCallback& 63 const BackgroundSyncService::DuplicateRegistrationHandleCallback&
64 callback); 64 callback);
65 65
66 private: 66 private:
67 // Callback handlers 67 // Callback handlers
68 void RegisterCallback( 68 void RegisterCallback(
69 scoped_ptr<blink::WebSyncRegistrationCallbacks> callbacks, 69 scoped_ptr<blink::WebSyncRegistrationCallbacks> callbacks,
(...skipping 20 matching lines...) Expand all
90 90
91 ServiceRegistry* service_registry_; 91 ServiceRegistry* service_registry_;
92 BackgroundSyncServicePtr background_sync_service_; 92 BackgroundSyncServicePtr background_sync_service_;
93 93
94 DISALLOW_COPY_AND_ASSIGN(BackgroundSyncProvider); 94 DISALLOW_COPY_AND_ASSIGN(BackgroundSyncProvider);
95 }; 95 };
96 96
97 } // namespace content 97 } // namespace content
98 98
99 #endif // CONTENT_CHILD_BACKGROUND_SYNC_BACKGROUND_SYNC_PROVIDER_H_ 99 #endif // CONTENT_CHILD_BACKGROUND_SYNC_BACKGROUND_SYNC_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698