Always set the serialized state object for history navigations.

Always set the serialized state object for history navigations.

The state object should always be injected for history navigations if
one exists, but the new document should only be loaded for non-push
history navigations.

BUG=483709
Committed: https://crrev.com/a15f6f0cd8664fbc4a74094df75b622cc87391ee
Cr-Commit-Position: refs/heads/master@{#350066}

[kkhorimoto, 2015-09-17 22:25:57]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, stuartmorgan@chromium.org

[Eugene But (OOO till 7-30), 2015-09-18 02:02:36]

lgtm with nits

https://codereview.chromium.org/1353503003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.h (right):

https://codereview.chromium.org/1353503003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.h:194: -
(void)setPushedOrReplacedURL:(const GURL&)url
Since this method is not called anywhere, lets take a chance to move it to
implementation file.

https://codereview.chromium.org/1353503003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.h:194: -
(void)setPushedOrReplacedURL:(const GURL&)url
NIT: s/url/URL (including changes in the comments)

https://codereview.chromium.org/1353503003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.h:306: //
|setPushedOrReplacedURL:stateObject:|. |fromEntry| is the
NIT: I think mentioning setPushedOrReplacedURL:stateObject: is unnecessary here
(especially if you move that method to implementation file).

[kkhorimoto, 2015-09-21 22:55:13]

https://codereview.chromium.org/1353503003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.h (right):

https://codereview.chromium.org/1353503003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.h:194: -
(void)setPushedOrReplacedURL:(const GURL&)url
On 2015/09/18 02:02:36, eugenebut wrote:
> NIT: s/url/URL (including changes in the comments)

Done.

https://codereview.chromium.org/1353503003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.h:306: //
|setPushedOrReplacedURL:stateObject:|. |fromEntry| is the
On 2015/09/18 02:02:36, eugenebut wrote:
> NIT: I think mentioning setPushedOrReplacedURL:stateObject: is unnecessary
here
> (especially if you move that method to implementation file).

Done.

[kkhorimoto, 2015-09-21 22:55:16]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2015-09-21 22:55:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1353503003/#ps20001
(title: "Eugene's nits")

[commit-bot: I haz the power, 2015-09-21 22:55:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353503003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353503003/20001

[commit-bot: I haz the power, 2015-09-21 23:44:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-21 23:47:23]

Patchset 2 (id:??) landed as
https://crrev.com/a15f6f0cd8664fbc4a74094df75b622cc87391ee
Cr-Commit-Position: refs/heads/master@{#350066}