Always set the serialized state object for history navigations.

ios/web/web_state/ui/crw_web_controller.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_WEB_STATE_UI_CRW_WEB_CONTROLLER_H_
 #define IOS_WEB_WEB_STATE_UI_CRW_WEB_CONTROLLER_H_
 
 #import <UIKit/UIKit.h>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 167 matching lines @@
 // YES if the CRWWebController's view is deemed appropriate for saving in order
 // to generate an overlay placeholder view.
 - (BOOL)canUseViewForGeneratingOverlayPlaceholderView;
 
 // Start loading the URL specified in |originalParams|, with the specified
 // settings.  Always resets the openedByScript property to NO.
 - (void)loadWithParams:(const web::WebLoadParams&)originalParams;
 
 // Loads the URL indicated by current session state.
 - (void)loadCurrentURL;
-// Updates UIWebView's URL and urlOnStartLoading_ during back/forward navigation
-// over pushed URLs. Needed so that sites that depend on URL params/fragment
-// continue to work correctly and checks for the URL don't incorrectly trigger
-// -pageChanged calls.
-- (void)finishPushStateNavigationToURL:(const GURL&)url
-                       withStateObject:(NSString*)stateObject;
+// Injects JavaScript into the web view to update the URL to |url|, to set
+// window.history.state to |stateObject|, and to trigger a popstate() event.
+// Upon the scripts completion, resets |urlOnStartLoading_| and
+// |_lastRegisteredRequestURL| to |url|.  This is necessary so that sites that
+// depend on URL params/fragments continue to work correctly and that checks for
+// the URL don't incorrectly trigger |-pageChanged| calls.
+- (void)setPushedOrReplacedURL:(const GURL&)url

[Eugene But (OOO till 7-30), 2015/09/18 02:02:35]

Since this method is not called anywhere, lets take a chance to move it to
implementation file.

[Eugene But (OOO till 7-30), 2015/09/18 02:02:36]

NIT: s/url/URL (including changes in the comments)

[kkhorimoto, 2015/09/21 22:55:13]

Done.

+                   stateObject:(NSString*)stateObject;
 // Loads the HTML into the page.
 - (void)loadHTML:(NSString*)html;
 // Loads HTML in the page and presents it as if it was originating from an
 // application specific URL.
 - (void)loadHTML:(NSString*)HTML forAppSpecificURL:(const GURL&)URL;
 
 // Causes the page to start loading immediately if there is a pending load;
 // normally if the web view has been paged out for memory reasons, loads are
 // started lazily the next time the view is displayed. This can be called to
 // bypass the lazy behavior. This is equivalent to calling -view, but should be
@@ skipping 90 matching lines @@
 - (void)loadErrorInNativeView:(NSError*)error;
 
 // Resets the state of a page where a load was rejected. This method must
 // be called if an embedder rejected the page load (e.g. by returning NO from
 // |-[WebDelegate shouldOpenURL:linkClicked:]|) but wants to continue working
 // with CRWWebController.
 - (void)restoreStateAfterURLRejection;
 
 // Helper method called at the end of history navigation methods goBack,
 // goForward, and goDelta. Determines whether to load a new URL or call
-// |finishPushStateNavigationToURL:withStateObject:|. |fromEntry| is the
+// |setPushedOrReplacedURL:stateObject:|. |fromEntry| is the

[Eugene But (OOO till 7-30), 2015/09/18 02:02:36]

NIT: I think mentioning setPushedOrReplacedURL:stateObject: is unnecessary here
(especially if you move that method to implementation file).

[kkhorimoto, 2015/09/21 22:55:13]

Done.

 // CRWSessionEntry that was the current entry prior to the navigation.
 // TODO(rohitrao): This is only exposed so Tab can call it temporarily.  Remove
 // as soon as all the Tab calls have moved into CRWWebController.
 - (void)finishHistoryNavigationFromEntry:(CRWSessionEntry*)fromEntry;
 
 // Returns the native controller (if any) current mananging the content.
 - (id<CRWNativeContent>)nativeController;
 @end
 
 #pragma mark Testing
@@ skipping 15 matching lines @@
 // Returns the header height.
 - (CGFloat)headerHeight;
 
 // Caches request POST data in the given session entry.  Exposed for testing.
 - (void)cachePOSTDataForRequest:(NSURLRequest*)request
                  inSessionEntry:(CRWSessionEntry*)currentSessionEntry;
 
 @end
 
 #endif  // IOS_WEB_WEB_STATE_UI_CRW_WEB_CONTROLLER_H_