Make submit_try accept space- or comma-separated list

Make submit_try accept space- or comma-separated list
(SkipBuildbotRuns)
Committed: https://code.google.com/p/skia/source/detail?r=8521

[borenet, 2013-04-03 18:19:18]

LGTM

https://codereview.chromium.org/13535005/diff/1/tools/submit_try
File tools/submit_try (left):

https://codereview.chromium.org/13535005/diff/1/tools/submit_try#oldcode187
tools/submit_try:187: else:
I had envisioned just changing this else-case to be something like:

else:
  bots_to_add = bot.split(',')
  for bot_to_add in bots_to_add:
    if not bot in trybots:
      Error(....)
  using_bots.extend(bots_to_add)

I think this works pretty much the same as what you did though.

[epoger, 2013-04-03 18:29:11]

https://codereview.chromium.org/13535005/diff/1/tools/submit_try
File tools/submit_try (left):

https://codereview.chromium.org/13535005/diff/1/tools/submit_try#oldcode187
tools/submit_try:187: else:
On 2013/04/03 18:19:18, borenet wrote:
> I had envisioned just changing this else-case to be something like:
> 
> else:
>   bots_to_add = bot.split(',')
>   for bot_to_add in bots_to_add:
>     if not bot in trybots:
>       Error(....)
>   using_bots.extend(bots_to_add)
> 
> I think this works pretty much the same as what you did though.

I thought about that, but it wouldn't account for ALL_BUILDERS being specified
within a comma-separated list (although that's illegal anyway)

You inspired me to try it a different way... PTAL and let me know if you're OK
with the approach in patchset 2 instead!

[borenet, 2013-04-03 18:32:13]

On 2013/04/03 18:29:11, epoger wrote:
> https://codereview.chromium.org/13535005/diff/1/tools/submit_try
> File tools/submit_try (left):
> 
> https://codereview.chromium.org/13535005/diff/1/tools/submit_try#oldcode187
> tools/submit_try:187: else:
> On 2013/04/03 18:19:18, borenet wrote:
> > I had envisioned just changing this else-case to be something like:
> > 
> > else:
> >   bots_to_add = bot.split(',')
> >   for bot_to_add in bots_to_add:
> >     if not bot in trybots:
> >       Error(....)
> >   using_bots.extend(bots_to_add)
> > 
> > I think this works pretty much the same as what you did though.
> 
> I thought about that, but it wouldn't account for ALL_BUILDERS being specified
> within a comma-separated list (although that's illegal anyway)
> 
> You inspired me to try it a different way... PTAL and let me know if you're OK
> with the approach in patchset 2 instead!

Even better!  The only problem I see (which was already there) is that I can
specify "all" as long as it comes before any other builders:

submit_try --bot all Skia_Linux_NoGPU_Debug_32

[epoger, 2013-04-03 18:35:21]

> Even better!  The only problem I see (which was already there) is that I can
> specify "all" as long as it comes before any other builders:

I'll leave that for another day. :-)

[epoger, 2013-04-03 18:35:39]

Committed patchset #2 manually as r8521 (presubmit successful).