Make submit_try accept space- or comma-separated list

tools/submit_try

 #!/usr/bin/python
 
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """
 submit_try: Submit a try request.
 
@@ skipping 158 matching lines @@
     if arg == '-h' or arg == '--help':
       Error()
     elif arg == '-l' or arg == '--list_bots':
       print 'submit_try: Available builders:\n  %s' % '\n  '.join(trybots)
       sys.exit(0)
     elif arg == '-b' or arg == '--bot':
       if using_bots:
         Error('--bot specified multiple times.')
       if len(argv) < 1:
         Error('You must specify a builder with "--bot".')
+      botlist_firstpass_string = ''
+      while argv and not argv[0].startswith('-'):
+        botlist_firstpass_string += argv.pop(0)
+        botlist_firstpass_string += ' '
       using_bots = []
-      while argv and not argv[0].startswith('-'):
-        bot = argv.pop(0)
+      for bot in botlist_firstpass_string.replace(',', ' ').split():
         if bot == ALL_BUILDERS:
           if using_bots:
             Error('Cannot specify "all" with additional builder names.')
           using_bots = trybots
           break
         else:

[borenet, 2013/04/03 18:19:18]

I had envisioned just changing this else-case to be something like:

else:
  bots_to_add = bot.split(',')
  for bot_to_add in bots_to_add:
    if not bot in trybots:
      Error(....)
  using_bots.extend(bots_to_add)

I think this works pretty much the same as what you did though.

[epoger, 2013/04/03 18:29:12]

I thought about that, but it wouldn't account for ALL_BUILDERS being specified
within a comma-separated list (although that's illegal anyway)

You inspired me to try it a different way... PTAL and let me know if you're OK
with the approach in patchset 2 instead!

           if not bot in trybots:
             Error('Unrecognized builder: %s' % bot)
           using_bots.append(bot)
     elif arg == '-r':
       if len(argv) < 1:
         Error('You must specify a revision with "-r".')
       revision = argv.pop(0)
     else:
       if changelist or not is_svn:
         Error('Unknown argument: %s' % arg)
@@ skipping 56 matching lines @@
   is_svn = os.path.isdir('.svn')
 
   # Parse and validate the command-line arguments.
   args = ValidateArgs(sys.argv[1:], trybots=trybots, is_svn=is_svn)
 
   # Submit the try request.
   SubmitTryRequest(args, is_svn=is_svn)
 
 
 if __name__ == '__main__':
-  sys.exit(main())
+  sys.exit(main())