chromeos/network/onc/onc_certificate_importer_impl_unittest.cc - Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FakeShillManagerClient::SetInitialNetworkState Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/network_connection_handler.cc ('K') | « chromeos/network/network_connection_handler.cc ('k') | chromeos/network/shill_property_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

diff --git a/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc b/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

index 35ff424149eec34d2566c132de663842e0f61632..f98cb5bdf5d09b3f51c4e57d39c8259e3af351d6 100644

--- a/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

+++ b/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

@@ -97,7 +97,8 @@ class ONCCertificateImporterImplTest : public testing::Test {

web_trust_certificates_ = onc_trusted_certificates;

}

- void AddCertificatesFromFile(std::string filename, bool expected_success) {

+ void AddCertificatesFromFile(const std::string& filename,

+ bool expected_success) {

scoped_ptr<base::DictionaryValue> onc =

test_utils::ReadTestDictionary(filename);

scoped_ptr<base::Value> certificates_value;

« chromeos/network/network_connection_handler.cc ('K') | « chromeos/network/network_connection_handler.cc ('k') | chromeos/network/shill_property_util.h » ('j') | no next file with comments »