chromeos/network/network_connection_handler.cc - Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_connection_handler.cc

Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FakeShillManagerClient::SetInitialNetworkState Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/dbus/fake_shill_manager_client.cc ('K') | « chromeos/network/network_connection_handler.h ('k') | chromeos/network/onc/onc_certificate_importer_impl_unittest.cc » ('j') | chromeos/network/onc/onc_certificate_importer_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/network_connection_handler.cc

diff --git a/chromeos/network/network_connection_handler.cc b/chromeos/network/network_connection_handler.cc

index e8c49396ba43b295dd1b3b19259b8d0cb5c92a66..af187ee01ceb86b660624fa9a270b88936bf2c75 100644

--- a/chromeos/network/network_connection_handler.cc

+++ b/chromeos/network/network_connection_handler.cc

@@ -656,7 +656,7 @@ void NetworkConnectionHandler::HandleShillConnectFailure(

}

void NetworkConnectionHandler::CheckPendingRequest(

- const std::string service_path) {

+ const std::string& service_path) {

ConnectRequest* request = GetPendingRequest(service_path);

DCHECK(request);

if (request->connect_state == ConnectRequest::CONNECT_REQUESTED)