chromeos/dbus/fake_shill_manager_client.h - Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_manager_client.h

Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FakeShillManagerClient::SetInitialNetworkState Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/audio/audio_devices_pref_handler_impl.cc ('k') | chromeos/dbus/fake_shill_manager_client.cc » ('j') | chromeos/dbus/fake_shill_manager_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/dbus/fake_shill_manager_client.h

diff --git a/chromeos/dbus/fake_shill_manager_client.h b/chromeos/dbus/fake_shill_manager_client.h

index 313a2d43e58e523a7cef3b1f2696c796039399da..5e142ed0d42d9eacd00ed44e3c685a0721b65c35 100644

--- a/chromeos/dbus/fake_shill_manager_client.h

+++ b/chromeos/dbus/fake_shill_manager_client.h

@@ -126,7 +126,8 @@ class CHROMEOS_EXPORT FakeShillManagerClient

// {wifi,cellular,etc}={on,off,disabled,none} - sets initial state for type

void ParseCommandLineSwitch();

bool ParseOption(const std::string& arg0, const std::string& arg1);

- bool SetInitialNetworkState(std::string type_arg, std::string state_arg);

+ bool SetInitialNetworkState(const std::string& type_arg,

+ const std::string& state_arg);

std::string GetInitialStateForType(const std::string& type,

bool* enabled);