chromeos/audio/audio_devices_pref_handler_impl.cc - Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/audio/audio_devices_pref_handler_impl.cc

Issue 1353323002: Cleanup: Pass std::string as const reference from chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FakeShillManagerClient::SetInitialNetworkState Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/audio/audio_devices_pref_handler_impl.h ('k') | chromeos/dbus/fake_shill_manager_client.h » ('j') | chromeos/dbus/fake_shill_manager_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/audio/audio_devices_pref_handler_impl.cc

diff --git a/chromeos/audio/audio_devices_pref_handler_impl.cc b/chromeos/audio/audio_devices_pref_handler_impl.cc

index 4e72de6c1ca6ac4bf2e597d3330e5a502170583e..17b5681ebce457ca4feffe8a9f1479fa95ee4832 100644

--- a/chromeos/audio/audio_devices_pref_handler_impl.cc

+++ b/chromeos/audio/audio_devices_pref_handler_impl.cc

@@ -187,14 +187,14 @@ void AudioDevicesPrefHandlerImpl::SaveDevicesVolumePref() {

}

void AudioDevicesPrefHandlerImpl::MigrateDeviceMuteSettings(

- std::string active_device) {

+ const std::string& active_device) {

int old_mute = local_state_->GetInteger(prefs::kAudioMute);

device_mute_settings_->SetInteger(active_device, old_mute);

SaveDevicesMutePref();

}

void AudioDevicesPrefHandlerImpl::MigrateDeviceVolumeSettings(

- std::string active_device) {

+ const std::string& active_device) {

double old_volume = local_state_->GetDouble(prefs::kAudioVolumePercent);

device_volume_settings_->SetDouble(active_device, old_volume);

SaveDevicesVolumePref();