Make __proto__ a real JavaScript accessor property.

Make __proto__ a real JavaScript accessor property.

This turns the __proto__ callback from a foreign callback into a real
JavaScript accessor. It makes the accessor behavior of this property
explicit.

R=rossberg@chromium.org
BUG=v8:1949, v8:2606
TEST=mjsunit/regress/regress-2606

Committed: http://code.google.com/p/v8/source/detail?r=14139

[rossberg, 2013-04-03 13:42:23]

LGTM, modulo the missing poisoning.

https://codereview.chromium.org/13533004/diff/2001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/13533004/diff/2001/src/v8natives.js#newcode73
src/v8natives.js:73: // Helper function to install a getter/setter accessor
property/
Nit: / -> . at the end

https://codereview.chromium.org/13533004/diff/2001/src/v8natives.js#newcode74
src/v8natives.js:74: function InstallGetterSetter(object, name, getter, setter)
{
Maybe cook up names that make clear that this function and the previous one also
differ in terms of native vs non-native.

[Michael Starzinger, 2013-04-04 09:48:02]

Addressed comments. Implemented poisoning.

https://codereview.chromium.org/13533004/diff/2001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/13533004/diff/2001/src/v8natives.js#newcode73
src/v8natives.js:73: // Helper function to install a getter/setter accessor
property/
On 2013/04/03 13:42:23, rossberg wrote:
> Nit: / -> . at the end

Done.

https://codereview.chromium.org/13533004/diff/2001/src/v8natives.js#newcode74
src/v8natives.js:74: function InstallGetterSetter(object, name, getter, setter)
{
On 2013/04/03 13:42:23, rossberg wrote:
> Maybe cook up names that make clear that this function and the previous one
also
> differ in terms of native vs non-native.

Done. Oops, totally missed the boilerplate to adapt getter and setter.

[rossberg, 2013-04-04 09:58:43]

https://codereview.chromium.org/13533004/diff/2004/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/13533004/diff/2004/src/v8natives.js#newcode409
src/v8natives.js:409: return { get: desc.getGet() === ObjectGetProto ?
ObjectPoisonProto
I don't think there is a need (or the intention) to poison the getter as well,
since you can always get a prototype with Object.getPrototypeOf anyway.

[Michael Starzinger, 2013-04-04 11:52:19]

https://codereview.chromium.org/13533004/diff/2004/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/13533004/diff/2004/src/v8natives.js#newcode409
src/v8natives.js:409: return { get: desc.getGet() === ObjectGetProto ?
ObjectPoisonProto
On 2013/04/04 09:58:43, rossberg wrote:
> I don't think there is a need (or the intention) to poison the getter as well,
> since you can always get a prototype with Object.getPrototypeOf anyway.

Done.

[rossberg, 2013-04-04 11:58:00]

lgtm

[Michael Starzinger, 2013-04-04 12:10:41]

Committed patchset #6 manually as r14139 (presubmit successful).