Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1353103002: [turbofan] Use StringCompareStub for string comparisons. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@StringCompare
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use StringCompareStub for string comparisons. R=jarin@chromium.org Committed: https://crrev.com/eaef361791a827df365292b14c271d861dc76d39 Cr-Commit-Position: refs/heads/master@{#30821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M src/compiler/simplified-lowering.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +13 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-18 08:53:13 UTC) #1
Jarin
lgtm
5 years, 3 months ago (2015-09-18 09:49:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353103002/1
5 years, 3 months ago (2015-09-18 10:17:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 10:18:47 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 10:19:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaef361791a827df365292b14c271d861dc76d39
Cr-Commit-Position: refs/heads/master@{#30821}

Powered by Google App Engine
This is Rietveld 408576698