Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 1347913003: [stubs] Refactor StringCompareStub and use it for HStringCompareAndBranch. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Refactor StringCompareStub and use it for HStringCompareAndBranch. The StringCompareStub used to take its parameters on the (JavaScript) stack, which made it impossible to use in TurboFan. Actually StringCompareStub was currently completely unused. This changes the calling convention to something TurboFan compatible and introduces a CallInterfaceDescriptor for StringCompareStub. It also changes HStringCompareAndBranch to use the StringCompareStub instead of using the full blown CompareICStub for a stupid string comparison. R=jarin@chromium.org Committed: https://crrev.com/8016547c8e6fde00fff0a1791f3c83b444d8af25 Cr-Commit-Position: refs/heads/master@{#30818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -202 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +14 lines, -15 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +20 lines, -27 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +10 lines, -14 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +14 lines, -16 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +15 lines, -16 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +17 lines, -18 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +15 lines, -18 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +5 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-18 08:05:31 UTC) #1
Benedikt Meurer
Hey Jaro, This is the first cleanup step for String comparison we were talking about. ...
5 years, 3 months ago (2015-09-18 08:06:20 UTC) #2
Jarin
lgtm
5 years, 3 months ago (2015-09-18 08:20:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347913003/1
5 years, 3 months ago (2015-09-18 08:21:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 08:30:31 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 08:30:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8016547c8e6fde00fff0a1791f3c83b444d8af25
Cr-Commit-Position: refs/heads/master@{#30818}

Powered by Google App Engine
This is Rietveld 408576698