Handle RESCAN events from the Bluetooth chooser by starting or extending a discovery session.

Handle RESCAN events from the Bluetooth chooser by starting or extending a discovery session.

I also added interfaces to support tests that this works, documented in https://github.com/WebBluetoothCG/web-bluetooth/pull/165.

BUG=533185
TBR=mkwst@chromium.org

Committed: https://crrev.com/1e9f0c90c10d405dacfe7ab9b5ae4c1c05227a98
Cr-Commit-Position: refs/heads/master@{#350586}

[Jeffrey Yasskin, 2015-09-18 01:04:41]

jyasskin@chromium.org changed reviewers:
+ ortuno@chromium.org, scheib@chromium.org

[Jeffrey Yasskin, 2015-09-18 01:51:42]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 01:51:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/1

[commit-bot: I haz the power, 2015-09-18 02:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 02:50:16]

Dry run: This issue passed the CQ dry run.

[ortuno, 2015-09-18 19:31:56]

lgtm

https://codereview.chromium.org/1353053002/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.h (right):

https://codereview.chromium.org/1353053002/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.h:64: void
StartDiscovery(RequestDeviceSession* session, int chooser_id);
Should this be named StartDeviceDiscovery? In case we have other types of
Discovery Sessions like service discovery or characteristic discovery?

[Jeffrey Yasskin, 2015-09-18 21:29:49]

jyasskin@chromium.org changed reviewers:
+ armansito@chromium.org, mkwst@chromium.org

[Jeffrey Yasskin, 2015-09-18 21:29:50]

Mike, please check content/shell/browser/blink_test_controller.cc.
Arman, please check the extra observer support in MockBluetoothAdapter.

https://codereview.chromium.org/1353053002/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.h (right):

https://codereview.chromium.org/1353053002/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.h:64: void
StartDiscovery(RequestDeviceSession* session, int chooser_id);
On 2015/09/18 19:31:56, ortuno wrote:
> Should this be named StartDeviceDiscovery? In case we have other types of
> Discovery Sessions like service discovery or characteristic discovery?

Yeah, good point. Done.

[armansito, 2015-09-18 23:33:50]

https://codereview.chromium.org/1353053002/diff/20001/device/bluetooth/test/m...
File device/bluetooth/test/mock_bluetooth_adapter.cc (right):

https://codereview.chromium.org/1353053002/diff/20001/device/bluetooth/test/m...
device/bluetooth/test/mock_bluetooth_adapter.cc:25: }));
Do you ever need MockBluetoothAdapter::AddObserver|RemoveObserver to be mocked
in tests? Why not just not override them in this class at all?

[Jeffrey Yasskin, 2015-09-19 00:16:12]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[Jeffrey Yasskin, 2015-09-19 00:16:47]

https://codereview.chromium.org/1353053002/diff/20001/device/bluetooth/test/m...
File device/bluetooth/test/mock_bluetooth_adapter.cc (right):

https://codereview.chromium.org/1353053002/diff/20001/device/bluetooth/test/m...
device/bluetooth/test/mock_bluetooth_adapter.cc:25: }));
On 2015/09/18 23:33:49, armansito wrote:
> Do you ever need MockBluetoothAdapter::AddObserver|RemoveObserver to be mocked
> in tests? Why not just not override them in this class at all?

My tests don't need it; let's see if anyone else's do. Changed.

[commit-bot: I haz the power, 2015-09-19 00:16:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/40001

[commit-bot: I haz the power, 2015-09-19 00:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-19 00:26:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[armansito, 2015-09-19 02:29:13]

On 2015/09/19 00:26:11, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Looks like the mocks are indeed being used from some webbluetooth unit tests but
then again it might be better to remove those expectations from those tests
anyway since these probably don't really serve a good purpose as expectations.

[Jeffrey Yasskin, 2015-09-23 00:55:26]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 00:56:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/60001

[Jeffrey Yasskin, 2015-09-23 01:00:01]

jyasskin@chromium.org changed reviewers:
+ kalman@chromium.org, tengs@chromium.org

[Jeffrey Yasskin, 2015-09-23 01:00:01]

On 2015/09/19 02:29:13, armansito wrote:
> On 2015/09/19 00:26:11, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> >   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> Looks like the mocks are indeed being used from some webbluetooth unit tests
but
> then again it might be better to remove those expectations from those tests
> anyway since these probably don't really serve a good purpose as expectations.


Several of these expectations look like they're asserting that the components
clean up after themselves as they're being destroyed, which is fairly valuable
to avoid use-after-free's. + some representatives of the teams whose assertions
we'd be removing. I'm inclined to revert that part of the change.

[commit-bot: I haz the power, 2015-09-23 01:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 01:31:39]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[armansito, 2015-09-23 02:18:06]

On 2015/09/23 01:00:01, Jeffrey Yasskin wrote:
> On 2015/09/19 02:29:13, armansito wrote:
> > On 2015/09/19 00:26:11, commit-bot: I haz the power wrote:
> > > Dry run: Try jobs failed on following builders:
> > >   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > >   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> > 
> > Looks like the mocks are indeed being used from some webbluetooth unit tests
> but
> > then again it might be better to remove those expectations from those tests
> > anyway since these probably don't really serve a good purpose as
expectations.
> 
> 
> Several of these expectations look like they're asserting that the components
> clean up after themselves as they're being destroyed, which is fairly valuable
> to avoid use-after-free's. + some representatives of the teams whose
assertions
> we'd be removing. I'm inclined to revert that part of the change.

sgtm. Pre-emptive lgtm

[Jeffrey Yasskin, 2015-09-23 02:21:41]

jyasskin@chromium.org changed reviewers:
- kalman@chromium.org, tengs@chromium.org

[Jeffrey Yasskin, 2015-09-23 02:25:09]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 02:25:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/80001

[Jeffrey Yasskin, 2015-09-23 02:26:16]

Thanks. Mike and Vince, I still need your LGTMs for content/shell and
content/shell/layout_tests/*bluetooth.

[scheib, 2015-09-23 03:35:00]

LGTM, comment request:

https://codereview.chromium.org/1353053002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1353053002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:257:
static void AddDevice(scoped_refptr<NiceMockBluetoothAdapter> adapter,
This is hard enough to trace code flow to warrant a comment explaining it.
Briefly here and possibly at the use below as well.

[commit-bot: I haz the power, 2015-09-23 04:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 04:06:58]

Dry run: This issue passed the CQ dry run.

[Jeffrey Yasskin, 2015-09-23 19:32:04]

jyasskin@chromium.org changed reviewers:
+ jochen@chromium.org

[Jeffrey Yasskin, 2015-09-23 19:32:05]

Hey Jochen, Mike's marked "slow" and I'm going on vacation Saturday, so can you
look at the 2 lines in
https://codereview.chromium.org/1353053002/diff/120001/content/shell/browser/...

FYI to others: Since the blink merge is done, I merged in the tests Gio approved
in https://codereview.chromium.org/1348953004/.

https://codereview.chromium.org/1353053002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1353053002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:257:
static void AddDevice(scoped_refptr<NiceMockBluetoothAdapter> adapter,
On 2015/09/23 03:35:00, scheib wrote:
> This is hard enough to trace code flow to warrant a comment explaining it.
> Briefly here and possibly at the use below as well.

Done.

[Jeffrey Yasskin, 2015-09-23 19:32:10]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 19:32:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/120001

[commit-bot: I haz the power, 2015-09-23 19:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 19:33:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jeffrey Yasskin, 2015-09-23 21:08:58]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 21:09:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/120001

[commit-bot: I haz the power, 2015-09-23 21:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:09:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jeffrey Yasskin, 2015-09-23 21:26:26]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 21:27:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/140001

[commit-bot: I haz the power, 2015-09-23 22:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 22:14:51]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jeffrey Yasskin, 2015-09-24 16:36:37]

The CQ bit was checked by jyasskin@chromium.org

[Jeffrey Yasskin, 2015-09-24 16:36:37]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org,
armansito@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1353053002/#ps140001
(title: "Sync")

[commit-bot: I haz the power, 2015-09-24 16:37:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/140001

[commit-bot: I haz the power, 2015-09-24 16:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 16:48:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jeffrey Yasskin, 2015-09-24 16:48:56]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2015-09-24 16:50:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353053002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353053002/140001

[Mike West, 2015-09-24 16:53:59]

lgtm

[commit-bot: I haz the power, 2015-09-24 16:58:38]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-09-24 16:59:42]

Patchset 8 (id:??) landed as
https://crrev.com/1e9f0c90c10d405dacfe7ab9b5ae4c1c05227a98
Cr-Commit-Position: refs/heads/master@{#350586}