Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: content/browser/bluetooth/bluetooth_dispatcher_host.cc

Issue 1353053002: Handle RESCAN events from the Bluetooth chooser by starting or extending a discovery session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Sync Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_dispatcher_host.cc
diff --git a/content/browser/bluetooth/bluetooth_dispatcher_host.cc b/content/browser/bluetooth/bluetooth_dispatcher_host.cc
index c1a2395c4f2bb918ab826e0a4242535217dbd999..75556c0b319d3f4b7bc0656813429e7fd04545a1 100644
--- a/content/browser/bluetooth/bluetooth_dispatcher_host.cc
+++ b/content/browser/bluetooth/bluetooth_dispatcher_host.cc
@@ -243,6 +243,20 @@ struct BluetoothDispatcherHost::RequestDeviceSession {
}
}
+ scoped_ptr<device::BluetoothDiscoveryFilter> ComputeScanFilter() const {
+ std::set<BluetoothUUID> services;
+ for (const BluetoothScanFilter& filter : filters) {
+ services.insert(filter.services.begin(), filter.services.end());
+ }
+ scoped_ptr<device::BluetoothDiscoveryFilter> discovery_filter(
+ new device::BluetoothDiscoveryFilter(
+ device::BluetoothDiscoveryFilter::TRANSPORT_DUAL));
+ for (const BluetoothUUID& service : services) {
+ discovery_filter->AddUUID(service);
+ }
+ return discovery_filter.Pass();
+ }
+
const int thread_id;
const int request_id;
const std::vector<BluetoothScanFilter> filters;
@@ -261,6 +275,24 @@ void BluetoothDispatcherHost::set_adapter(
adapter_->AddObserver(this);
}
+void BluetoothDispatcherHost::StartDeviceDiscovery(
+ RequestDeviceSession* session,
+ int chooser_id) {
+ if (session->discovery_session) {
+ // Already running; just increase the timeout.
+ discovery_session_timer_.Reset();
+ } else {
+ session->chooser->ShowDiscoveryState(
+ BluetoothChooser::DiscoveryState::DISCOVERING);
+ adapter_->StartDiscoverySessionWithFilter(
+ session->ComputeScanFilter(),
+ base::Bind(&BluetoothDispatcherHost::OnDiscoverySessionStarted,
+ weak_ptr_factory_.GetWeakPtr(), chooser_id),
+ base::Bind(&BluetoothDispatcherHost::OnDiscoverySessionStartedError,
+ weak_ptr_factory_.GetWeakPtr(), chooser_id));
+ }
+}
+
void BluetoothDispatcherHost::StopDeviceDiscovery() {
for (IDMap<RequestDeviceSession, IDMapOwnPointer>::iterator iter(
&request_device_sessions_);
@@ -315,21 +347,6 @@ void BluetoothDispatcherHost::DeviceRemoved(device::BluetoothAdapter* adapter,
}
}
-static scoped_ptr<device::BluetoothDiscoveryFilter> ComputeScanFilter(
- const std::vector<BluetoothScanFilter>& filters) {
- std::set<BluetoothUUID> services;
- for (const BluetoothScanFilter& filter : filters) {
- services.insert(filter.services.begin(), filter.services.end());
- }
- scoped_ptr<device::BluetoothDiscoveryFilter> discovery_filter(
- new device::BluetoothDiscoveryFilter(
- device::BluetoothDiscoveryFilter::TRANSPORT_DUAL));
- for (const BluetoothUUID& service : services) {
- discovery_filter->AddUUID(service);
- }
- return discovery_filter.Pass();
-}
-
void BluetoothDispatcherHost::OnRequestDevice(
int thread_id,
int request_id,
@@ -425,15 +442,7 @@ void BluetoothDispatcherHost::OnRequestDevice(
return;
}
- // Redundant with the chooser's default; just to be clear:
- session->chooser->ShowDiscoveryState(
- BluetoothChooser::DiscoveryState::DISCOVERING);
- adapter_->StartDiscoverySessionWithFilter(
- ComputeScanFilter(filters),
- base::Bind(&BluetoothDispatcherHost::OnDiscoverySessionStarted,
- weak_ptr_factory_.GetWeakPtr(), chooser_id),
- base::Bind(&BluetoothDispatcherHost::OnDiscoverySessionStartedError,
- weak_ptr_factory_.GetWeakPtr(), chooser_id));
+ StartDeviceDiscovery(session, chooser_id);
}
void BluetoothDispatcherHost::OnConnectGATT(
@@ -721,18 +730,18 @@ void BluetoothDispatcherHost::OnBluetoothChooserEvent(
int chooser_id,
BluetoothChooser::Event event,
const std::string& device_id) {
+ RequestDeviceSession* session = request_device_sessions_.Lookup(chooser_id);
+ DCHECK(session) << "Shouldn't receive an event (" << static_cast<int>(event)
+ << ") from a closed chooser.";
+ CHECK(session->chooser) << "Shouldn't receive an event ("
+ << static_cast<int>(event)
+ << ") from a closed chooser.";
switch (event) {
case BluetoothChooser::Event::RESCAN:
- // TODO(jyasskin): Implement starting a new Bluetooth discovery session.
- NOTIMPLEMENTED();
+ StartDeviceDiscovery(session, chooser_id);
break;
case BluetoothChooser::Event::CANCELLED:
case BluetoothChooser::Event::SELECTED: {
- RequestDeviceSession* session =
- request_device_sessions_.Lookup(chooser_id);
- DCHECK(session) << "Shouldn't close the dialog twice.";
- CHECK(session->chooser) << "Shouldn't close the dialog twice.";
-
// Synchronously ensure nothing else calls into the chooser after it has
// asked to be closed.
session->chooser.reset();
« no previous file with comments | « content/browser/bluetooth/bluetooth_dispatcher_host.h ('k') | content/shell/browser/blink_test_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698