Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353043002: Revert of add a ClassID function to GrBatch (Closed)

Created:
5 years, 3 months ago by reed2
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add a ClassID function to GrBatch (patchset #5 id:80001 of https://codereview.chromium.org/1352813003/ ) Reason for revert: Speculative revert to unblock DEPS roll Original issue's description: > add a ClassID function to GrBatch > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4078d529e9e199eea13456db7bf3a63a104ab5b9 > > Committed: https://skia.googlesource.com/skia/+/eb44d53cf96a7eaf103a98d76079ce1f5495e343 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/48e3a45ade15c52c0c1a10cb00907dd444897745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -201 lines) Patch
M gm/beziereffects.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 5 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 14 chunks +20 lines, -35 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 6 chunks +15 lines, -26 lines 0 comments Download
M src/gpu/batches/GrBatch.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrClearBatch.h View 3 chunks +4 lines, -12 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDiscardBatch.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 4 chunks +5 lines, -9 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStencilPathBatch.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/batches/GrTInstanceBatch.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrVertexBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 4 chunks +3 lines, -7 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of add a ClassID function to GrBatch
5 years, 3 months ago (2015-09-18 00:34:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353043002/1
5 years, 3 months ago (2015-09-18 00:34:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/48e3a45ade15c52c0c1a10cb00907dd444897745
5 years, 3 months ago (2015-09-18 00:35:18 UTC) #3
reed2
5 years, 3 months ago (2015-09-18 03:15:47 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1344373005/ by reed@chromium.org.

The reason for reverting is: DEPS roll seems to have landed w/o this revert, so
revert it again.

Powered by Google App Engine
This is Rietveld 408576698