Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1353023004: Remove GN group backward-compat code. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GN group backward-compat code. This backwards-compat code automatically promoted a group's deps to be public if there were no public deps defined. This was done to make the transition to adding public/private deps easier. Dependent on: https://codereview.chromium.org/1356493004/ (chrome) https://codereview.chromium.org/1351203002/ (blink) https://codereview.chromium.org/1356723002/ (v8) Committed: https://crrev.com/2616020c823cbf4cba3f1ad05f042952b8bacb05 Cr-Commit-Position: refs/heads/master@{#352071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/gn/group_target_generator.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 3 months ago (2015-09-17 22:29:51 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-17 23:12:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353023004/1
5 years, 2 months ago (2015-10-02 17:35:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 17:53:34 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 17:54:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2616020c823cbf4cba3f1ad05f042952b8bacb05
Cr-Commit-Position: refs/heads/master@{#352071}

Powered by Google App Engine
This is Rietveld 408576698