Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: tools/gn/group_target_generator.cc

Issue 1353023004: Remove GN group backward-compat code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/group_target_generator.cc
diff --git a/tools/gn/group_target_generator.cc b/tools/gn/group_target_generator.cc
index 707d275ef9234fcba8e0565627d61e3df743ed9d..2c427f4cc49ab1b5f9a9d5f2f3fb10bda8a5d935 100644
--- a/tools/gn/group_target_generator.cc
+++ b/tools/gn/group_target_generator.cc
@@ -22,13 +22,4 @@ void GroupTargetGenerator::DoRun() {
target_->set_output_type(Target::GROUP);
// Groups only have the default types filled in by the target generator
// base class.
-
- // Before there was a deps/public_deps split, a group acted like all deps
- // are public. During a transition period, if public_deps is not defined,
- // treat all deps as public. This should be removed and existing groups
- // updated to use "public_deps" when needed.
- if (scope_->GetValue(variables::kDeps, false) &&
- !scope_->GetValue(variables::kPublicDeps, false)) {
- std::swap(target_->private_deps(), target_->public_deps());
- }
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698