Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: content/child/child_io_surface_manager_mac.cc

Issue 1352913003: Mac: Don't CHECK that AcquireIOSurface succeeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/child_io_surface_manager_mac.cc
diff --git a/content/child/child_io_surface_manager_mac.cc b/content/child/child_io_surface_manager_mac.cc
index b3408463087cde6406e18a4a92a6f3b969d28b76..883defe99b56fde5ff351de244b022e0145d00bb 100644
--- a/content/child/child_io_surface_manager_mac.cc
+++ b/content/child/child_io_surface_manager_mac.cc
@@ -128,11 +128,10 @@ IOSurfaceRef ChildIOSurfaceManager::AcquireIOSurface(
MACH_LOG(ERROR, kr) << "mach_msg";
return nullptr;
}
-
- // Crash the renderer (for now) to see if this was the cause of renderer hangs
- // that have recently been noticed.
- // http://crbug.com/532149
- CHECK(data.reply.msg.result);
+ if (!data.reply.msg.result) {
+ DLOG(ERROR) << "Browser refused AcquireIOSurface request";
+ return nullptr;
+ }
// Deallocate the right after creating an IOSurface reference.
base::mac::ScopedMachSendRight scoped_io_surface_right(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698