permissions: add layout tests for multiple requests

permissions: add layout tests for multiple requests

No permisisons, single, multiple and duplicate permissions
are all tested. Permission updates being reflected in the request
is also tested.

This CL depends on https://codereview.chromium.org/1352863002/
as it adds the ability to reset permisisons.

BUG=516626
Committed: https://crrev.com/3f93847acbf05646881eddde65fc285eb60d8556
Cr-Commit-Position: refs/heads/master@{#350677}

[Lalit Maganti, 2015-09-17 18:18:30]

lalitm@google.com changed reviewers:
+ mlamouri@chromium.org

[Lalit Maganti, 2015-09-17 18:18:31]

Mounir: FYI for after the dependencies land.

[Lalit Maganti, 2015-09-17 20:01:05]

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
File
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js
(right):

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:93:
function runTest(i) {
Should probably factor this out into the helper file. It's come up 3 times now
and it's become quite complex.

[mlamouri (slow - plz ping), 2015-09-23 14:24:28]

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
File
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js
(right):

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:37:
callback();
Could you call navigator.permissions.revoke():
  navigator.permissions.revoke({name:'geolocation'}).then(callback);

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:52:
return setPermission('geolocation', 'granted', location.origin,
location.origin);
Could you set notifications to 'prompt'?

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:61:
callback();
Could you add another test with geolocation/notifications being inverted?

[Lalit Maganti, 2015-09-24 09:26:43]

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
File
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js
(right):

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:37:
callback();
On 2015/09/23 14:24:28, Mounir Lamouri wrote:
> Could you call navigator.permissions.revoke():
>   navigator.permissions.revoke({name:'geolocation'}).then(callback);

Done.

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:52:
return setPermission('geolocation', 'granted', location.origin,
location.origin);
On 2015/09/23 14:24:28, Mounir Lamouri wrote:
> Could you set notifications to 'prompt'?

Done.

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:61:
callback();
On 2015/09/23 14:24:28, Mounir Lamouri wrote:
> Could you add another test with geolocation/notifications being inverted?

Done.

https://codereview.chromium.org/1352863003/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:93:
function runTest(i) {
On 2015/09/17 20:01:05, Lalit Maganti wrote:
> Should probably factor this out into the helper file. It's come up 3 times now
> and it's become quite complex.

Maybe not since reset was removed

[mlamouri (slow - plz ping), 2015-09-24 11:12:42]

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:37:
return setPermission('geolocation', 'denied', location.origin, location.origin);
nit: add a comment saying "// Cleanup."

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:54:
return setPermission('notifications', 'prompt', location.origin,
location.origin);
could you check the intermediary state here? (ie. do request())

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:63:
return setPermission('geolocation', 'denied', location.origin, location.origin);
ditto

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:65:
return setPermission('notifications', 'denied', location.origin,
location.origin);
Actually, could you do above:
  return Promise.all([setPermission('geolocation', 'denied', ...),
setPermission('notifications', 'denied', ...)]);

minus typos and inability to write JS on the spot

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:82:
return setPermission('geolocation', 'prompt', location.origin, location.origin);
could you check the intermediary state here? (ie. do request())

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-sharedworker.html
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-sharedworker.html:4:
<title>Permissions API: test .revoke() method.</title>
Hmm, the name doesn't sound quite right.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-window.html
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-window.html:4:
<title>Permissions API: test .revoke() method.</title>
ditto

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-worker.html
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-worker.html:4:
<title>Permissions API: test .request() method.</title>
Could you update the name to say it's for multiple requests?

[Lalit Maganti, 2015-09-24 11:24:36]

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:37:
return setPermission('geolocation', 'denied', location.origin, location.origin);
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> nit: add a comment saying "// Cleanup."

Done.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:54:
return setPermission('notifications', 'prompt', location.origin,
location.origin);
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> could you check the intermediary state here? (ie. do request())

Done.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:63:
return setPermission('geolocation', 'denied', location.origin, location.origin);
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> ditto

Done.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:65:
return setPermission('notifications', 'denied', location.origin,
location.origin);
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> Actually, could you do above:
>   return Promise.all([setPermission('geolocation', 'denied', ...),
> setPermission('notifications', 'denied', ...)]);
> 
> minus typos and inability to write JS on the spot

Done.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:82:
return setPermission('geolocation', 'prompt', location.origin, location.origin);
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> could you check the intermediary state here? (ie. do request())

Done.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-sharedworker.html
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-sharedworker.html:4:
<title>Permissions API: test .revoke() method.</title>
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> Hmm, the name doesn't sound quite right.

Ugh thought I fixed this.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-window.html
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-window.html:4:
<title>Permissions API: test .revoke() method.</title>
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> ditto

Done.

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-worker.html
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-worker.html:4:
<title>Permissions API: test .request() method.</title>
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> Could you update the name to say it's for multiple requests?

Done.

[Lalit Maganti, 2015-09-24 12:43:39]

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js
(right):

https://codereview.chromium.org/1352863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js:65:
return setPermission('notifications', 'denied', location.origin,
location.origin);
On 2015/09/24 11:12:42, Mounir Lamouri wrote:
> Actually, could you do above:
>   return Promise.all([setPermission('geolocation', 'denied', ...),
> setPermission('notifications', 'denied', ...)]);
> 
> minus typos and inability to write JS on the spot

Realised that Promise.all does not work with the workers because there are all
sorts of cross promise issues with your custom test setPermission magic.
Switched back to chained set.

[Lalit Maganti, 2015-09-24 13:50:10]

Mounir: should be good now. PTAL.

[mlamouri (slow - plz ping), 2015-09-24 15:09:50]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-09-24 15:09:51]

lgtm

[commit-bot: I haz the power, 2015-09-24 15:10:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352863003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352863003/120001

[commit-bot: I haz the power, 2015-09-24 17:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 17:15:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Lalit Maganti, 2015-09-24 20:26:00]

The CQ bit was checked by lalitm@google.com

[Lalit Maganti, 2015-09-24 20:26:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1352863003/#ps140001
(title: "Attempt to fix Windows bot")

[commit-bot: I haz the power, 2015-09-24 20:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352863003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352863003/140001

[commit-bot: I haz the power, 2015-09-24 21:54:29]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-09-24 21:55:20]

Patchset 8 (id:??) landed as
https://crrev.com/3f93847acbf05646881eddde65fc285eb60d8556
Cr-Commit-Position: refs/heads/master@{#350677}

[Michael van Ouwerkerk, 2015-09-25 15:15:19]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1369723002/ by mvanouwerkerk@chromium.org.

The reason for reverting is: Oddly one test is failing on Win7: 535931. Sorry
for the revert..