permissions: rework tests for requesting

permissions: rework tests for requesting

This CL does several things:
(1) The lack of using a variable inside the inner request meant the
request test was just testing setPermisison. Fix the test by making it
use promises and make the error message more descriptive as well.
(2) Fix some broken comments.

BUG=(none)

Committed: https://crrev.com/bd0128bccd3ecffc322939931764930333e7aa46
Cr-Commit-Position: refs/heads/master@{#350532}

[Lalit Maganti, 2015-09-17 16:20:53]

lalitm@google.com changed reviewers:
+ mlamouri@chromium.org

[Lalit Maganti, 2015-09-17 16:20:59]

Mounir: PTAL

[Lalit Maganti, 2015-09-17 17:35:41]

OK actually ignore this for now because although the initial fix was simple,
turns out there's actually quite a lot broken with the latest patch. Requires
some test runner changes and Worker wizardry.

[mlamouri (slow - plz ping), 2015-09-23 14:27:41]

Please, ping me when you want me to have a look at that again.

[Lalit Maganti, 2015-09-23 14:28:51]

On 2015/09/23 14:27:41, Mounir Lamouri wrote:
> Please, ping me when you want me to have a look at that again.

Much of this change can be removed if reset is not landing so I'll rework based
on that.

[Lalit Maganti, 2015-09-24 11:14:52]

Monir: PTAL. This should be ready for landing now.

[mlamouri (slow - plz ping), 2015-09-24 11:17:31]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-09-24 11:17:32]

lgtm

[commit-bot: I haz the power, 2015-09-24 11:17:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352863002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352863002/120001

[commit-bot: I haz the power, 2015-09-24 11:22:21]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-09-24 11:23:15]

Patchset 7 (id:??) landed as
https://crrev.com/bd0128bccd3ecffc322939931764930333e7aa46
Cr-Commit-Position: refs/heads/master@{#350532}