content/browser/web_contents/web_contents_impl.h - Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More test fixes and improvements but the code is stil a WIP! Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index d0a567006d8bf7563f6a2c30446e78d4853d1bb4..76e6c159cc20b9c34eb00ed5eeeed1503859ff4f 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -427,6 +427,7 @@ class CONTENT_EXPORT WebContentsImpl

RenderFrameHost* target_rfh,

SiteInstance* source_site_instance) const override;

void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) override;

+ scoped_ptr<WebUIImpl> CreateWebUIForRenderManager(const GURL& url) override;

#if defined(OS_WIN)

gfx::NativeViewAccessible GetParentNativeViewAccessible() override;

#endif

@@ -618,7 +619,6 @@ class CONTENT_EXPORT WebContentsImpl

RenderViewHost* old_host,

RenderViewHost* new_host) override;

NavigationControllerImpl& GetControllerForRenderManager() override;

- scoped_ptr<WebUIImpl> CreateWebUIForRenderManager(const GURL& url) override;

NavigationEntry* GetLastCommittedNavigationEntryForRenderManager() override;

bool FocusLocationBarByDefault() override;

void SetFocusToLocationBar(bool select_all) override;