Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 1352813006: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More test fixes and improvements but the code is stil a WIP! Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 RenderFrameHost* GetGuestByInstanceID( 420 RenderFrameHost* GetGuestByInstanceID(
421 RenderFrameHost* render_frame_host, 421 RenderFrameHost* render_frame_host,
422 int browser_plugin_instance_id) override; 422 int browser_plugin_instance_id) override;
423 GeolocationServiceContext* GetGeolocationServiceContext() override; 423 GeolocationServiceContext* GetGeolocationServiceContext() override;
424 void EnterFullscreenMode(const GURL& origin) override; 424 void EnterFullscreenMode(const GURL& origin) override;
425 void ExitFullscreenMode() override; 425 void ExitFullscreenMode() override;
426 bool ShouldRouteMessageEvent( 426 bool ShouldRouteMessageEvent(
427 RenderFrameHost* target_rfh, 427 RenderFrameHost* target_rfh,
428 SiteInstance* source_site_instance) const override; 428 SiteInstance* source_site_instance) const override;
429 void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) override; 429 void EnsureOpenerProxiesExist(RenderFrameHost* source_rfh) override;
430 scoped_ptr<WebUIImpl> CreateWebUIForRenderManager(const GURL& url) override;
430 #if defined(OS_WIN) 431 #if defined(OS_WIN)
431 gfx::NativeViewAccessible GetParentNativeViewAccessible() override; 432 gfx::NativeViewAccessible GetParentNativeViewAccessible() override;
432 #endif 433 #endif
433 434
434 // RenderViewHostDelegate ---------------------------------------------------- 435 // RenderViewHostDelegate ----------------------------------------------------
435 RenderViewHostDelegateView* GetDelegateView() override; 436 RenderViewHostDelegateView* GetDelegateView() override;
436 bool OnMessageReceived(RenderViewHost* render_view_host, 437 bool OnMessageReceived(RenderViewHost* render_view_host,
437 const IPC::Message& message) override; 438 const IPC::Message& message) override;
438 // RenderFrameHostDelegate has the same method, so list it there because this 439 // RenderFrameHostDelegate has the same method, so list it there because this
439 // interface is going away. 440 // interface is going away.
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 RenderViewHost* render_view_host) override; 612 RenderViewHost* render_view_host) override;
612 void UpdateRenderViewSizeForRenderManager() override; 613 void UpdateRenderViewSizeForRenderManager() override;
613 void CancelModalDialogsForRenderManager() override; 614 void CancelModalDialogsForRenderManager() override;
614 void NotifySwappedFromRenderManager(RenderFrameHost* old_host, 615 void NotifySwappedFromRenderManager(RenderFrameHost* old_host,
615 RenderFrameHost* new_host, 616 RenderFrameHost* new_host,
616 bool is_main_frame) override; 617 bool is_main_frame) override;
617 void NotifyMainFrameSwappedFromRenderManager( 618 void NotifyMainFrameSwappedFromRenderManager(
618 RenderViewHost* old_host, 619 RenderViewHost* old_host,
619 RenderViewHost* new_host) override; 620 RenderViewHost* new_host) override;
620 NavigationControllerImpl& GetControllerForRenderManager() override; 621 NavigationControllerImpl& GetControllerForRenderManager() override;
621 scoped_ptr<WebUIImpl> CreateWebUIForRenderManager(const GURL& url) override;
622 NavigationEntry* GetLastCommittedNavigationEntryForRenderManager() override; 622 NavigationEntry* GetLastCommittedNavigationEntryForRenderManager() override;
623 bool FocusLocationBarByDefault() override; 623 bool FocusLocationBarByDefault() override;
624 void SetFocusToLocationBar(bool select_all) override; 624 void SetFocusToLocationBar(bool select_all) override;
625 bool IsHidden() override; 625 bool IsHidden() override;
626 int GetOuterDelegateFrameTreeNodeID() override; 626 int GetOuterDelegateFrameTreeNodeID() override;
627 627
628 // NotificationObserver ------------------------------------------------------ 628 // NotificationObserver ------------------------------------------------------
629 629
630 void Observe(int type, 630 void Observe(int type,
631 const NotificationSource& source, 631 const NotificationSource& source,
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
1326 // Adds/removes a callback called on creation of each new WebContents. 1326 // Adds/removes a callback called on creation of each new WebContents.
1327 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1327 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1328 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1328 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1329 1329
1330 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1330 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1331 }; 1331 };
1332 1332
1333 } // namespace content 1333 } // namespace content
1334 1334
1335 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1335 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698