Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1352693002: Add a rappor metric for getting package names for custom tabs clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 2a9c0afb7de2a51eeeb0368aae572b8d5b35c4ce..00384808cbb24d0e0e1281b937b5eef1b102bbe7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -33,6 +33,7 @@ import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
import org.chromium.chrome.browser.appmenu.ChromeAppMenuPropertiesDelegate;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel.StateChangeReason;
import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument;
+import org.chromium.chrome.browser.rappor.RapporServiceBridge;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.SingleTabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
@@ -234,9 +235,23 @@ public class CustomTabActivity extends ChromeActivity {
};
loadUrlInCurrentTab(new LoadUrlParams(url),
IntentHandler.getTimestampFromIntent(getIntent()));
+ recordClientPackageName();
super.finishNativeInitialization();
}
+ private void recordClientPackageName() {
+ final String packageName = CustomTabsConnection.getInstance(getApplication())
+ .getClientPackageNameForSession(mSession);
+ if (TextUtils.isEmpty(packageName) || packageName.contains(getPackageName())) return;
+ ThreadUtils.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ RapporServiceBridge.sampleString(
+ "CustomTabs.ServiceClient.PackageName", packageName);
+ }
+ });
+ }
+
@Override
public void onStartWithNative() {
super.onStartWithNative();

Powered by Google App Engine
This is Rietveld 408576698