Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1352613002: add test for skbug.com/4351 (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix warning #

Total comments: 2

Patch Set 3 : add comment as to the origin of the test bitmap we use #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -0 lines) Patch
M tests/ReadPixelsTest.cpp View 1 2 1 chunk +171 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
reed1
ptal
5 years, 3 months ago (2015-09-16 19:15:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352613002/1
5 years, 3 months ago (2015-09-16 19:15:47 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-16 19:15:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/3339)
5 years, 3 months ago (2015-09-16 19:17:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352613002/20001
5 years, 3 months ago (2015-09-16 19:19:50 UTC) #9
reed1
now with augmented comment
5 years, 3 months ago (2015-09-16 19:43:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352613002/40001
5 years, 3 months ago (2015-09-16 19:43:56 UTC) #12
robertphillips
lgtm - not sure about the naming stuff https://codereview.chromium.org/1352613002/diff/20001/tests/ReadPixelsTest.cpp File tests/ReadPixelsTest.cpp (right): https://codereview.chromium.org/1352613002/diff/20001/tests/ReadPixelsTest.cpp#newcode569 tests/ReadPixelsTest.cpp:569: // ...
5 years, 3 months ago (2015-09-16 19:49:29 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 19:50:33 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/34482bb79e45dd23dd05b268afc13e7c52b180af

Powered by Google App Engine
This is Rietveld 408576698