Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: tests/ReadPixelsTest.cpp

Issue 1352543003: disable test for all quality levels, since it is driver dependent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ReadPixelsTest.cpp
diff --git a/tests/ReadPixelsTest.cpp b/tests/ReadPixelsTest.cpp
index 5076a614f44cb7cf244ffaf4679fbf41c72a262e..b5f84170bccfbd23735ab9a0675bf71cb10dc0a0 100644
--- a/tests/ReadPixelsTest.cpp
+++ b/tests/ReadPixelsTest.cpp
@@ -596,18 +596,21 @@ DEF_GPUTEST(ReadPixels_Subset_Gpu, reporter, factory) {
SkAutoTUnref<SkSurface> surfA(SkSurface::NewRenderTarget(ctx, SkSurface::kNo_Budgeted, info, 0));
SkAutoTUnref<SkSurface> surfB(SkSurface::NewRenderTarget(ctx, SkSurface::kNo_Budgeted, info, 0));
- //
- // BUG: if we change this to kNone_SkFilterQuality or kHigh_SkFilterQuality, it fails
- //
- SkFilterQuality quality = kLow_SkFilterQuality;
-
- SkAutoTUnref<SkData> dataA(draw_into_surface(surfA, bm_subset, quality));
- SkAutoTUnref<SkData> dataB(draw_into_surface(surfB, tx_subset, quality));
-
- REPORTER_ASSERT(reporter, dataA->equals(dataB));
if (false) {
- dump_to_file("test_image_A.png", dataA);
- dump_to_file("test_image_B.png", dataB);
+ //
+ // BUG: depending on the driver, if we calls this with various quality settings, it
+ // may fail.
+ //
+ SkFilterQuality quality = kLow_SkFilterQuality;
+
+ SkAutoTUnref<SkData> dataA(draw_into_surface(surfA, bm_subset, quality));
+ SkAutoTUnref<SkData> dataB(draw_into_surface(surfB, tx_subset, quality));
+
+ REPORTER_ASSERT(reporter, dataA->equals(dataB));
+ if (false) {
+ dump_to_file("test_image_A.png", dataA);
+ dump_to_file("test_image_B.png", dataB);
+ }
}
}
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698