Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: tests/ReadPixelsTest.cpp

Issue 1352543003: disable test for all quality levels, since it is driver dependent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkCanvas.h" 8 #include "SkCanvas.h"
9 #include "SkColorPriv.h" 9 #include "SkColorPriv.h"
10 #include "SkMathPriv.h" 10 #include "SkMathPriv.h"
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 GrWrapTextureInBitmap(subsetTx, tmp_subset.width(), tmp_subset.height(), tru e, &bm_subset); 589 GrWrapTextureInBitmap(subsetTx, tmp_subset.width(), tmp_subset.height(), tru e, &bm_subset);
590 590
591 // did we get the same subset? 591 // did we get the same subset?
592 compare_textures(reporter, bm_subset.getTexture(), tx_subset.getTexture()); 592 compare_textures(reporter, bm_subset.getTexture(), tx_subset.getTexture());
593 593
594 // do they draw the same? 594 // do they draw the same?
595 const SkImageInfo info = SkImageInfo::MakeN32Premul(128, 128); 595 const SkImageInfo info = SkImageInfo::MakeN32Premul(128, 128);
596 SkAutoTUnref<SkSurface> surfA(SkSurface::NewRenderTarget(ctx, SkSurface::kNo _Budgeted, info, 0)); 596 SkAutoTUnref<SkSurface> surfA(SkSurface::NewRenderTarget(ctx, SkSurface::kNo _Budgeted, info, 0));
597 SkAutoTUnref<SkSurface> surfB(SkSurface::NewRenderTarget(ctx, SkSurface::kNo _Budgeted, info, 0)); 597 SkAutoTUnref<SkSurface> surfB(SkSurface::NewRenderTarget(ctx, SkSurface::kNo _Budgeted, info, 0));
598 598
599 // 599 if (false) {
600 // BUG: if we change this to kNone_SkFilterQuality or kHigh_SkFilterQuality , it fails 600 //
601 // 601 // BUG: depending on the driver, if we calls this with various quality settings, it
602 SkFilterQuality quality = kLow_SkFilterQuality; 602 // may fail.
603 //
604 SkFilterQuality quality = kLow_SkFilterQuality;
603 605
604 SkAutoTUnref<SkData> dataA(draw_into_surface(surfA, bm_subset, quality)); 606 SkAutoTUnref<SkData> dataA(draw_into_surface(surfA, bm_subset, quality)) ;
605 SkAutoTUnref<SkData> dataB(draw_into_surface(surfB, tx_subset, quality)); 607 SkAutoTUnref<SkData> dataB(draw_into_surface(surfB, tx_subset, quality)) ;
606 608
607 REPORTER_ASSERT(reporter, dataA->equals(dataB)); 609 REPORTER_ASSERT(reporter, dataA->equals(dataB));
608 if (false) { 610 if (false) {
609 dump_to_file("test_image_A.png", dataA); 611 dump_to_file("test_image_A.png", dataA);
610 dump_to_file("test_image_B.png", dataB); 612 dump_to_file("test_image_B.png", dataB);
613 }
611 } 614 }
612 } 615 }
613 #endif 616 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698