net/dns/dns_query.cc - Issue 1352233002: Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_query.cc

Issue 1352233002: Returning scoped_ptr<> instead of raw pointer in DnsQuery::CloneWithNewId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_query.cc

diff --git a/net/dns/dns_query.cc b/net/dns/dns_query.cc

index 530508a61de1b3f051e5f7139aeef16ca3cce0bd..3a1ebca916adfcbd96ae8def71b3329a05e7c9d6 100644

--- a/net/dns/dns_query.cc

+++ b/net/dns/dns_query.cc

@@ -43,8 +43,8 @@ DnsQuery::DnsQuery(uint16 id, const base::StringPiece& qname, uint16 qtype)

DnsQuery::~DnsQuery() {

}

-DnsQuery* DnsQuery::CloneWithNewId(uint16 id) const {

- return new DnsQuery(*this, id);

+scoped_ptr<DnsQuery> DnsQuery::CloneWithNewId(uint16 id) const {

+ return scoped_ptr<DnsQuery>(new DnsQuery(*this, id));

eroman 2015/09/18 17:39:56 make_scoped_ptr(new DnsQuery(*this, id));

Paritosh Kumar 2015/09/21 09:38:43 Thanks. Done.

}

uint16 DnsQuery::id() const {

« no previous file with comments | « net/dns/dns_query.h ('k') | net/dns/dns_query_unittest.cc » ('j') | no next file with comments »