Issue 135213006: git_cl: Do not cache the relative root in Settings.

Issue 135213006: git_cl: Do not cache the relative root in Settings. (Closed)

Created:
6 years, 10 months ago by Lei Zhang

Modified:
6 years, 10 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

git_cl: Do not cache the relative root in Settings. Relative root no longer makes sense after an os.chdir(). This is effectively a partial revert of r250248. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=250478

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -18 lines)			Patch
	M	git_cl.py	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
	M	tests/git_cl_test.py	View		5 chunks	+7 lines, -12 lines	0 comments	Download

Total messages: 9 (0 generated)

Lei Zhang

I was testing git cl lint from a non-git-root directory and ran into strange errors...

6 years, 10 months ago (2014-02-11 10:50:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/135213006/1

6 years, 10 months ago (2014-02-11 18:30:14 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-11 18:32:01 UTC) #5

commit-bot: I haz the power

Presubmit check for 135213006-1 failed and returned exit status 1. Running presubmit commit checks ...

6 years, 10 months ago (2014-02-11 18:32:01 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/135213006/110001

6 years, 10 months ago (2014-02-11 19:55:30 UTC) #8

Message was sent while issue was closed.

Change committed as 250478