git_cl: Do not cache the relative root in Settings.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 from distutils.version import LooseVersion
@@ skipping 244 matching lines @@
   return subprocess2.call(
       ['git',
        'diff', '--no-ext-diff', '--stat'] + similarity_options + args,
       env=env)
 
 
 class Settings(object):
   def __init__(self):
     self.default_server = None
     self.cc = None
-    self.relative_root = None
+    self.root = None
     self.is_git_svn = None
     self.svn_branch = None
     self.tree_status_url = None
     self.viewvc_url = None
     self.updated = False
     self.is_gerrit = None
     self.git_editor = None
 
   def LazyUpdateIfNeeded(self):
     """Updates the settings from a codereview.settings file, if available."""
@@ skipping 20 matching lines @@
           self._GetRietveldConfig('server', error_ok=True))
       if error_ok:
         return self.default_server
       if not self.default_server:
         error_message = ('Could not find settings file. You must configure '
                          'your review setup by running "git cl config".')
         self.default_server = gclient_utils.UpgradeToHttps(
             self._GetRietveldConfig('server', error_message=error_message))
     return self.default_server
 
-  def GetRelativeRoot(self):
-    if self.relative_root is None:
-      self.relative_root = RunGit(['rev-parse', '--show-cdup']).strip()
-    return self.relative_root
+  @staticmethod
+  def GetRelativeRoot():
+    return RunGit(['rev-parse', '--show-cdup']).strip()
 
   def GetRoot(self):
-    return os.path.abspath(self.GetRelativeRoot())
+    if self.root is None:
+      self.root = os.path.abspath(self.GetRelativeRoot())
+    return self.root
 
   def GetIsGitSvn(self):
     """Return true if this repo looks like it's using git-svn."""
     if self.is_git_svn is None:
       # If you have any "svn-remote.*" config keys, we think you're using svn.
       self.is_git_svn = RunGitWithCode(
           ['config', '--local', '--get-regexp', r'^svn-remote\.'])[0] == 0
     return self.is_git_svn
 
   def GetSVNBranch(self):
@@ skipping 2106 matching lines @@
         ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
           'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
 
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   sys.exit(main(sys.argv[1:]))