Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 13521003: Revert 191287 "Revert 189210 "Add MODIFY_AUDIO_SETTINGS permissi..." (Closed)

Created:
7 years, 8 months ago by wjia(left Chromium)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, jochen+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Revert 191287 "Revert 189210 "Add MODIFY_AUDIO_SETTINGS permissi..." The workaround has been landed (https://src.chromium.org/viewvc/chrome?view=rev&revision=192248) and will be merged into M27. Reland the original patch. > Revert 189210 "Add MODIFY_AUDIO_SETTINGS permission in Android m..." > > It needs bluetooth permission on some devices. > > > Add MODIFY_AUDIO_SETTINGS permission in Android manifest and implementation in android audio manager. > > > > MODIFY_AUDIO_SETTINGS allows application to be able to configure audio settings. > > > > In android audio manager, a function SetAudioMode is added to set audio mode. > > > > BUG=180328 > > > > Contributed by leozwang@chromium.org (https://codereview.chromium.org/12571006/). > > Review URL: https://codereview.chromium.org/12843015 > > TBR=wjia@chromium.org > Review URL: https://codereview.chromium.org/13290002 TBR=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -14 lines) Patch
M chrome/android/testshell/java/AndroidManifest.xml View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/android/opensles_output.h View 1 chunk +3 lines, -2 lines 0 comments Download
M media/audio/audio_input_controller_unittest.cc View 4 chunks +30 lines, -4 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 4 chunks +26 lines, -4 lines 0 comments Download
M media/audio/audio_manager_base.h View 3 chunks +10 lines, -0 lines 0 comments Download
M media/audio/audio_manager_base.cc View 6 chunks +34 lines, -0 lines 0 comments Download
A + media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M media/base/android/media_jni_registrar.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M media/media.gyp View 2 chunks +3 lines, -2 lines 0 comments Download
M testing/android/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
wjia(left Chromium)
7 years, 8 months ago (2013-04-04 18:15:58 UTC) #1
wjia(left Chromium)
7 years, 8 months ago (2013-04-04 18:16:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r192369.

Powered by Google App Engine
This is Rietveld 408576698