Issue 13290002: Revert 189210 "Add MODIFY_AUDIO_SETTINGS permission in Android m..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13290002: Revert 189210 "Add MODIFY_AUDIO_SETTINGS permission in Android m..." (Closed)

Created:
7 years, 9 months ago by wjia(left Chromium)

Modified:
7 years, 9 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, jochen+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1453/src/

Visibility:
Public.

More Reviews

Description

Revert 189210 "Add MODIFY_AUDIO_SETTINGS permission in Android m..." It needs bluetooth permission on some devices. > Add MODIFY_AUDIO_SETTINGS permission in Android manifest and implementation in android audio manager. > > MODIFY_AUDIO_SETTINGS allows application to be able to configure audio settings. > > In android audio manager, a function SetAudioMode is added to set audio mode. > > BUG=180328 > > Contributed by leozwang@chromium.org (https://codereview.chromium.org/12571006/). > Review URL: https://codereview.chromium.org/12843015 TBR=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191287

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -138 lines)			Patch
M	chrome/android/testshell/java/AndroidManifest.xml	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/shell/android/browsertests_apk/AndroidManifest.xml	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/shell/android/shell_apk/AndroidManifest.xml	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	media/audio/android/opensles_output.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	media/audio/audio_input_controller_unittest.cc	View	4 chunks	+4 lines, -30 lines	0 comments	Download
M	media/audio/audio_input_unittest.cc	View	4 chunks	+4 lines, -26 lines	0 comments	Download
M	media/audio/audio_manager_base.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	media/audio/audio_manager_base.cc	View	6 chunks	+0 lines, -34 lines	0 comments	Download
D	media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	media/base/android/media_jni_registrar.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	media/media.gyp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	testing/android/AndroidManifest.xml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r191287.

Expand Messages | Collapse Messages