Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: mojo/package_manager/package_manager_impl.cc

Issue 1351963002: Some more minor cleanup to ApplicationManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/package_manager/package_manager_impl.cc
diff --git a/mojo/package_manager/package_manager_impl.cc b/mojo/package_manager/package_manager_impl.cc
index f1a1fc6bfb7be73f21c404c02923cc44b3d572c4..eccfb2ef25a9fe3116b5476cc352598505b8043b 100644
--- a/mojo/package_manager/package_manager_impl.cc
+++ b/mojo/package_manager/package_manager_impl.cc
@@ -10,6 +10,7 @@
#include "mojo/fetcher/switches.h"
#include "mojo/fetcher/update_fetcher.h"
#include "mojo/shell/application_manager.h"
+#include "mojo/shell/connect_util.h"
#include "mojo/shell/query_util.h"
#include "mojo/shell/switches.h"
#include "mojo/util/filename_util.h"
@@ -73,8 +74,8 @@ void PackageManagerImpl::FetchRequest(
// LocalFetcher uses the network service to infer MIME types from URLs.
// Skip this for mojo URLs to avoid recursively loading the network service.
if (!network_service_ && !url.SchemeIs("mojo")) {
- application_manager_->ConnectToService(GURL("mojo:network_service"),
- &network_service_);
+ shell::ConnectToService(application_manager_,
+ GURL("mojo:network_service"), &network_service_);
}
// Ownership of this object is transferred to |loader_callback|.
// TODO(beng): this is eff'n weird.
@@ -93,7 +94,8 @@ void PackageManagerImpl::FetchRequest(
if (url.SchemeIs("mojo") &&
base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kUseUpdater)) {
- application_manager_->ConnectToService(GURL("mojo:updater"), &updater_);
+ shell::ConnectToService(application_manager_, GURL("mojo:updater"),
+ &network_service_);
yzshen1 2015/09/17 20:49:11 &updater_
// Ownership of this object is transferred to |loader_callback|.
// TODO(beng): this is eff'n weird.
new fetcher::UpdateFetcher(url, updater_.get(), loader_callback);
@@ -102,8 +104,8 @@ void PackageManagerImpl::FetchRequest(
#endif
if (!url_loader_factory_) {
- application_manager_->ConnectToService(GURL("mojo:network_service"),
- &url_loader_factory_);
+ shell::ConnectToService(application_manager_, GURL("mojo:network_service"),
+ &url_loader_factory_);
}
// Ownership of this object is transferred to |loader_callback|.
« no previous file with comments | « mojo/mojo_shell.gyp ('k') | mojo/runner/context.cc » ('j') | mojo/shell/application_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698