Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: mojo/package_manager/package_manager_impl.cc

Issue 1351963002: Some more minor cleanup to ApplicationManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/package_manager/package_manager_impl.h" 5 #include "mojo/package_manager/package_manager_impl.h"
6 6
7 #include "mojo/fetcher/about_fetcher.h" 7 #include "mojo/fetcher/about_fetcher.h"
8 #include "mojo/fetcher/local_fetcher.h" 8 #include "mojo/fetcher/local_fetcher.h"
9 #include "mojo/fetcher/network_fetcher.h" 9 #include "mojo/fetcher/network_fetcher.h"
10 #include "mojo/fetcher/switches.h" 10 #include "mojo/fetcher/switches.h"
11 #include "mojo/fetcher/update_fetcher.h" 11 #include "mojo/fetcher/update_fetcher.h"
12 #include "mojo/shell/application_manager.h" 12 #include "mojo/shell/application_manager.h"
13 #include "mojo/shell/connect_util.h"
13 #include "mojo/shell/query_util.h" 14 #include "mojo/shell/query_util.h"
14 #include "mojo/shell/switches.h" 15 #include "mojo/shell/switches.h"
15 #include "mojo/util/filename_util.h" 16 #include "mojo/util/filename_util.h"
16 #include "url/gurl.h" 17 #include "url/gurl.h"
17 18
18 namespace mojo { 19 namespace mojo {
19 namespace package_manager { 20 namespace package_manager {
20 21
21 PackageManagerImpl::PackageManagerImpl( 22 PackageManagerImpl::PackageManagerImpl(
22 const base::FilePath& shell_file_root) 23 const base::FilePath& shell_file_root)
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 fetcher::AboutFetcher::Start(url, loader_callback); 67 fetcher::AboutFetcher::Start(url, loader_callback);
67 return; 68 return;
68 } 69 }
69 70
70 GURL resolved_url = ResolveURL(url); 71 GURL resolved_url = ResolveURL(url);
71 72
72 if (resolved_url.SchemeIsFile()) { 73 if (resolved_url.SchemeIsFile()) {
73 // LocalFetcher uses the network service to infer MIME types from URLs. 74 // LocalFetcher uses the network service to infer MIME types from URLs.
74 // Skip this for mojo URLs to avoid recursively loading the network service. 75 // Skip this for mojo URLs to avoid recursively loading the network service.
75 if (!network_service_ && !url.SchemeIs("mojo")) { 76 if (!network_service_ && !url.SchemeIs("mojo")) {
76 application_manager_->ConnectToService(GURL("mojo:network_service"), 77 shell::ConnectToService(application_manager_,
77 &network_service_); 78 GURL("mojo:network_service"), &network_service_);
78 } 79 }
79 // Ownership of this object is transferred to |loader_callback|. 80 // Ownership of this object is transferred to |loader_callback|.
80 // TODO(beng): this is eff'n weird. 81 // TODO(beng): this is eff'n weird.
81 new fetcher::LocalFetcher( 82 new fetcher::LocalFetcher(
82 network_service_.get(), resolved_url, 83 network_service_.get(), resolved_url,
83 shell::GetBaseURLAndQuery(resolved_url, nullptr), 84 shell::GetBaseURLAndQuery(resolved_url, nullptr),
84 loader_callback); 85 loader_callback);
85 return; 86 return;
86 } 87 }
87 88
88 #if 0 89 #if 0
89 // TODO(beng): figure out how this should be integrated now that mapped_url 90 // TODO(beng): figure out how this should be integrated now that mapped_url
90 // is toast. 91 // is toast.
91 // TODO(scottmg): to quote someone I know, if you liked this you shouldda put 92 // TODO(scottmg): to quote someone I know, if you liked this you shouldda put
92 // a test on it. 93 // a test on it.
93 if (url.SchemeIs("mojo") && 94 if (url.SchemeIs("mojo") &&
94 base::CommandLine::ForCurrentProcess()->HasSwitch( 95 base::CommandLine::ForCurrentProcess()->HasSwitch(
95 switches::kUseUpdater)) { 96 switches::kUseUpdater)) {
96 application_manager_->ConnectToService(GURL("mojo:updater"), &updater_); 97 shell::ConnectToService(application_manager_, GURL("mojo:updater"),
98 &network_service_);
yzshen1 2015/09/17 20:49:11 &updater_
97 // Ownership of this object is transferred to |loader_callback|. 99 // Ownership of this object is transferred to |loader_callback|.
98 // TODO(beng): this is eff'n weird. 100 // TODO(beng): this is eff'n weird.
99 new fetcher::UpdateFetcher(url, updater_.get(), loader_callback); 101 new fetcher::UpdateFetcher(url, updater_.get(), loader_callback);
100 return; 102 return;
101 } 103 }
102 #endif 104 #endif
103 105
104 if (!url_loader_factory_) { 106 if (!url_loader_factory_) {
105 application_manager_->ConnectToService(GURL("mojo:network_service"), 107 shell::ConnectToService(application_manager_, GURL("mojo:network_service"),
106 &url_loader_factory_); 108 &url_loader_factory_);
107 } 109 }
108 110
109 // Ownership of this object is transferred to |loader_callback|. 111 // Ownership of this object is transferred to |loader_callback|.
110 // TODO(beng): this is eff'n weird. 112 // TODO(beng): this is eff'n weird.
111 new fetcher::NetworkFetcher(disable_cache_, request.Pass(), 113 new fetcher::NetworkFetcher(disable_cache_, request.Pass(),
112 url_loader_factory_.get(), loader_callback); 114 url_loader_factory_.get(), loader_callback);
113 } 115 }
114 116
115 bool PackageManagerImpl::HandleWithContentHandler(shell::Fetcher* fetcher, 117 bool PackageManagerImpl::HandleWithContentHandler(shell::Fetcher* fetcher,
116 const GURL& unresolved_url, 118 const GURL& unresolved_url,
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 : std::string(); 165 : std::string();
164 *content_handler_url = alias_iter->second.first; 166 *content_handler_url = alias_iter->second.first;
165 return true; 167 return true;
166 } 168 }
167 169
168 return false; 170 return false;
169 } 171 }
170 172
171 } // namespace package_manager 173 } // namespace package_manager
172 } // namespace mojo 174 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/mojo_shell.gyp ('k') | mojo/runner/context.cc » ('j') | mojo/shell/application_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698