Some more minor cleanup to ApplicationManager.

Some more minor cleanup to ApplicationManager.

R=yzshen@chromium.org
http://crbug.com/533085

Committed: https://crrev.com/c6bde172a35b65b5a735675e840fab55921d28f8
Cr-Commit-Position: refs/heads/master@{#349515}

Committed: https://crrev.com/29dec844330333ee0aacb9beb5cfb58d7ba31d18
Cr-Commit-Position: refs/heads/master@{#349590}

[Ben Goodger (Google), 2015-09-17 19:32:15]

ben@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2015-09-17 20:49:11]

lgtm

https://codereview.chromium.org/1351963002/diff/40001/mojo/package_manager/pa...
File mojo/package_manager/package_manager_impl.cc (right):

https://codereview.chromium.org/1351963002/diff/40001/mojo/package_manager/pa...
mojo/package_manager/package_manager_impl.cc:98: &network_service_);
&updater_

https://codereview.chromium.org/1351963002/diff/40001/mojo/shell/application_...
File mojo/shell/application_manager.h (right):

https://codereview.chromium.org/1351963002/diff/40001/mojo/shell/application_...
mojo/shell/application_manager.h:61: // |originator| can be NULL (e.g. for the
first application or in tests), but
Please remove this sentence.

https://codereview.chromium.org/1351963002/diff/40001/mojo/shell/connect_util.cc
File mojo/shell/connect_util.cc (right):

https://codereview.chromium.org/1351963002/diff/40001/mojo/shell/connect_util...
mojo/shell/connect_util.cc:17: scoped_ptr<ConnectToApplicationParams> params(new
ConnectToApplicationParams);
Please consider adding includes.

[Ben Goodger (Google), 2015-09-17 20:59:22]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-09-17 20:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1351963002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2015-09-17 20:59:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351963002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351963002/60001

[commit-bot: I haz the power, 2015-09-17 22:13:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-17 22:14:12]

Patchset 4 (id:??) landed as
https://crrev.com/c6bde172a35b65b5a735675e840fab55921d28f8
Cr-Commit-Position: refs/heads/master@{#349515}

[Justin Donnelly, 2015-09-17 23:44:24]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1354043002/ by jdonnelly@chromium.org.

The reason for reverting is: Broke Android GN..

[Justin Donnelly, 2015-09-17 23:46:17]

On 2015/09/17 23:44:24, Justin Donnelly wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/1354043002/ by mailto:jdonnelly@chromium.org.
> 
> The reason for reverting is: Broke Android GN..

https://build.chromium.org/p/chromium.linux/builders/Android%20GN

[Justin Donnelly, 2015-09-18 00:26:43]

On 2015/09/17 23:46:17, Justin Donnelly wrote:
> On 2015/09/17 23:44:24, Justin Donnelly wrote:
> > A revert of this CL (patchset #4 id:60001) has been created in
> > https://codereview.chromium.org/1354043002/ by
mailto:jdonnelly@chromium.org.
> > 
> > The reason for reverting is: Broke Android GN..
> 
> https://build.chromium.org/p/chromium.linux/builders/Android%20GN

The revert didn't apply cleanly. Was there a follow on change to this?

[Justin Donnelly, 2015-09-18 00:43:27]

On 2015/09/18 00:26:43, Justin Donnelly wrote:
> On 2015/09/17 23:46:17, Justin Donnelly wrote:
> > On 2015/09/17 23:44:24, Justin Donnelly wrote:
> > > A revert of this CL (patchset #4 id:60001) has been created in
> > > https://codereview.chromium.org/1354043002/ by
> mailto:jdonnelly@chromium.org.
> > > 
> > > The reason for reverting is: Broke Android GN..
> > 
> > https://build.chromium.org/p/chromium.linux/builders/Android%20GN
> 
> The revert didn't apply cleanly. Was there a follow on change to this?

Found it: https://codereview.chromium.org/1354813002/

I'm reverting that then I'm going to try applying the revert of this CL again.

[Justin Donnelly, 2015-09-18 00:52:11]

On 2015/09/18 00:43:27, Justin Donnelly wrote:
> On 2015/09/18 00:26:43, Justin Donnelly wrote:
> > On 2015/09/17 23:46:17, Justin Donnelly wrote:
> > > On 2015/09/17 23:44:24, Justin Donnelly wrote:
> > > > A revert of this CL (patchset #4 id:60001) has been created in
> > > > https://codereview.chromium.org/1354043002/ by
> > mailto:jdonnelly@chromium.org.
> > > > 
> > > > The reason for reverting is: Broke Android GN..
> > > 
> > > https://build.chromium.org/p/chromium.linux/builders/Android%20GN
> > 
> > The revert didn't apply cleanly. Was there a follow on change to this?
> 
> Found it: https://codereview.chromium.org/1354813002/
> 
> I'm reverting that then I'm going to try applying the revert of this CL again.

Here's the first broken build:
https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/30420

And the error from the logs:

ERROR at //mandoline/app/android/mandoline_activity.cc:10:11: Can't include this
header from here.
#include "mojo/shell/connect_util.h"
          ^------------------------
The target:
  //mandoline/app/android:mandoline_runner
is including a file from the target:
  //mojo/shell:shell

It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.

Dependency chain (there may also be others):
  //mandoline/app/android:mandoline_runner -->
  //mojo/package_manager:package_manager --[private]-->
  //mojo/shell:shell

[Ben Goodger (Google), 2015-09-18 01:38:58]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-09-18 01:38:59]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1351963002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2015-09-18 01:39:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351963002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351963002/80001

[commit-bot: I haz the power, 2015-09-18 02:46:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-18 02:47:22]

Patchset 5 (id:??) landed as
https://crrev.com/29dec844330333ee0aacb9beb5cfb58d7ba31d18
Cr-Commit-Position: refs/heads/master@{#349590}