Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1351943004: Revert of Oilpan: Schedule a conservative GC when page navigations are happening frequently (Closed)

Created:
5 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 3 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Schedule a conservative GC when page navigations are happening frequently (patchset #2 id:20001 of https://codereview.chromium.org/1353283002/ ) Reason for revert: I believe this caused random crashes in the WebGL conformance tests on all platforms as described in http://crbug.com/534524 . Original issue's description: > Oilpan: Schedule a conservative GC when page navigations are happening frequently > > A frame retains a lot of memory in the V8 side. For example, one v8::Context retained > by the frame has >200 KB. V8's GC cannot collect the memory until Oilpan's GC collects > the frame. So this CL forces a conservative GC if no Oilpan's GC has been observed in > the past 5 frame navigations. > > This CL improves the performance of iframe-append-child as follows: > > ToT without Oilpan: 177 runs/sec > ToT with Oilpan: 142 runs/sec > ToT + this CL with Oilpan: 168 runs/sec > > This CL also reduces V8's peak memory usage as follows: > > ToT without Oilpan: 34 MB > ToT with Oilpan: 110 MB > ToT + this CL with Oilpan: 50 MB > > (Note: iframe-append-child uses little memory in the Blink side. > allocatedObjectSize + PartitionAlloc <= 4 MB.) > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202568 TBR=oilpan-reviews@chromium.org,keishi@chromium.org,sigbjornf@opera.se,sigbjornf@opera.com,haraken@chromium.org BUG=534524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/platform/heap/ThreadState.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/heap/ThreadState.cpp View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Ken Russell (switch to Gerrit)
Created Revert of Oilpan: Schedule a conservative GC when page navigations are happening frequently
5 years, 3 months ago (2015-09-21 22:17:55 UTC) #1
Ken Russell (switch to Gerrit)
FYI.
5 years, 3 months ago (2015-09-21 22:18:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351943004/1
5 years, 3 months ago (2015-09-21 22:19:13 UTC) #4
Ken Russell (switch to Gerrit)
On 2015/09/21 22:19:13, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-09-21 23:17:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202613
5 years, 3 months ago (2015-09-21 23:54:49 UTC) #6
haraken
5 years, 3 months ago (2015-09-21 23:58:25 UTC) #7
Message was sent while issue was closed.
On 2015/09/21 23:54:49, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=202613

Thanks for the revert, LGTM.

(This will be fixed in https://codereview.chromium.org/1358813002/.)

Powered by Google App Engine
This is Rietveld 408576698