Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1351943002: [arm64]: Fix bug introduced accidentally in r30710 (Closed)

Created:
5 years, 3 months ago by rmcilroy
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64]: Fix bug introduced accidentally in r30710 Uncomment the if (!serializer_enabled()) check which I accidentially left commented out after debugging during the CLs development. BUG=chromium:532969 R=bmeurer@chromium.org LOG=n Committed: https://crrev.com/2088752c709f3f921685e6bc27b2fe7fd22f2aac Cr-Commit-Position: refs/heads/master@{#30811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/arm64/assembler-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
rmcilroy
Benedikt, could you take a quick look please? Oops....
5 years, 3 months ago (2015-09-17 15:48:09 UTC) #2
rmcilroy
Michi: could you take a look please since Benedikt's already left?
5 years, 3 months ago (2015-09-17 15:59:52 UTC) #4
rmcilroy
TBRing.
5 years, 3 months ago (2015-09-17 16:44:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351943002/1
5 years, 3 months ago (2015-09-17 16:44:19 UTC) #7
Benedikt Meurer
LGTM
5 years, 3 months ago (2015-09-17 16:49:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5897)
5 years, 3 months ago (2015-09-17 17:05:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351943002/1
5 years, 3 months ago (2015-09-17 17:16:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 17:24:17 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 17:24:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2088752c709f3f921685e6bc27b2fe7fd22f2aac
Cr-Commit-Position: refs/heads/master@{#30811}

Powered by Google App Engine
This is Rietveld 408576698