Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1351933003: NaCl GN build: Remove some unneeded #defines (Closed)

Created:
5 years, 3 months ago by Mark Seaborn
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl GN build: Remove some unneeded #defines This syncs the GN build with Gyp. The per-OS #defines were removed from Gyp here: https://codereview.chromium.org/788193003 The per-arch #defines were removed from Gyp here: https://codereview.chromium.org/902903002 BUG=440012 TEST=build Committed: https://crrev.com/9ae8d7875f0ad6b8511940131640d920749982ec Cr-Commit-Position: refs/heads/master@{#349537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M build/config/nacl/BUILD.gn View 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 3 months ago (2015-09-17 19:44:40 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-17 20:07:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351933003/1
5 years, 3 months ago (2015-09-17 22:13:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 23:29:54 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 23:30:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ae8d7875f0ad6b8511940131640d920749982ec
Cr-Commit-Position: refs/heads/master@{#349537}

Powered by Google App Engine
This is Rietveld 408576698