Updating the GATT connection device address when it changes.

Updating the GATT connection device address when it changes.

The Bluetooth address of a connected device changes when the device
is paired while connected.

BUG=533449
Committed: https://crrev.com/26a8dc67bbef907d3b5266fd5b7edce2ca2cb1ed
Cr-Commit-Position: refs/heads/master@{#351037}

[sacomoto, 2015-09-18 14:46:24]

sacomoto@chromium.org changed reviewers:
+ armansito@chromium.org

[sacomoto, 2015-09-18 14:47:04]

PTAL.

[sacomoto, 2015-09-22 14:34:47]

On 2015/09/18 14:47:04, sacomoto wrote:
> PTAL.

@armansito, ping.

[armansito, 2015-09-23 06:46:59]

https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_gatt_connection_chromeos.cc (right):

https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_gatt_connection_chromeos.cc:103: // The remove
device's bluetooth address may change if it is paired while
nit: "The removed device's.."

https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_gatt_connection_chromeos.cc:106: device_address_ =
properties->address.value();
Won't you need to update the BluetoothDevice object as well?

[sacomoto, 2015-09-23 11:27:41]

https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_gatt_connection_chromeos.cc (right):

https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_gatt_connection_chromeos.cc:103: // The remove
device's bluetooth address may change if it is paired while
On 2015/09/23 06:46:59, armansito wrote:
> nit: "The removed device's.."

Done.

https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_gatt_connection_chromeos.cc:106: device_address_ =
properties->address.value();
On 2015/09/23 06:46:59, armansito wrote:
> Won't you need to update the BluetoothDevice object as well?

No. Only the DBus |object_path_| (not changed when a device is paired) is cached
on the BluetoothDevice object. The address is queried from the DBus API using
the |object_path_|.

On the other hand, the |DeviceMap| on the BluetoothAdapter should be updated
(see crbug.com/507699 and crbug.com/497841). I'll fix it in a next CL.

[sacomoto, 2015-09-23 17:46:35]

On 2015/09/23 11:27:41, sacomoto wrote:
>
https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
> File device/bluetooth/bluetooth_gatt_connection_chromeos.cc (right):
> 
>
https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
> device/bluetooth/bluetooth_gatt_connection_chromeos.cc:103: // The remove
> device's bluetooth address may change if it is paired while
> On 2015/09/23 06:46:59, armansito wrote:
> > nit: "The removed device's.."
> 
> Done.
> 
>
https://codereview.chromium.org/1351623006/diff/1/device/bluetooth/bluetooth_...
> device/bluetooth/bluetooth_gatt_connection_chromeos.cc:106: device_address_ =
> properties->address.value();
> On 2015/09/23 06:46:59, armansito wrote:
> > Won't you need to update the BluetoothDevice object as well?
> 
> No. Only the DBus |object_path_| (not changed when a device is paired) is
cached
> on the BluetoothDevice object. The address is queried from the DBus API using
> the |object_path_|.
> 
> On the other hand, the |DeviceMap| on the BluetoothAdapter should be updated
> (see crbug.com/507699 and crbug.com/497841). I'll fix it in a next CL.

I just saw that the issues with |DeviceMap| are fixed by this CL:

https://codereview.chromium.org/1341103004/

from jpawlowski@.

BTW, this CL is necessary regardless of that one.

[sacomoto, 2015-09-24 18:31:38]

Ping.

[armansito, 2015-09-25 18:38:07]

lgtm

[sacomoto, 2015-09-28 08:03:06]

The CQ bit was checked by sacomoto@chromium.org

[commit-bot: I haz the power, 2015-09-28 08:04:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351623006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351623006/40001

[commit-bot: I haz the power, 2015-09-28 08:38:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-28 08:39:12]

Patchset 3 (id:??) landed as
https://crrev.com/26a8dc67bbef907d3b5266fd5b7edce2ca2cb1ed
Cr-Commit-Position: refs/heads/master@{#351037}