Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: device/bluetooth/bluetooth_gatt_connection_chromeos.cc

Issue 1351623006: Updating the GATT connection device address when it changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/bluetooth/bluetooth_gatt_connection_chromeos.h" 5 #include "device/bluetooth/bluetooth_gatt_connection_chromeos.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chromeos/dbus/dbus_thread_manager.h" 9 #include "chromeos/dbus/dbus_thread_manager.h"
10 #include "device/bluetooth/bluetooth_adapter.h" 10 #include "device/bluetooth/bluetooth_adapter.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 GetProperties(object_path_); 92 GetProperties(object_path_);
93 93
94 if (!properties) { 94 if (!properties) {
95 connected_ = false; 95 connected_ = false;
96 return; 96 return;
97 } 97 }
98 98
99 if (property_name == properties->connected.name() && 99 if (property_name == properties->connected.name() &&
100 !properties->connected.value()) 100 !properties->connected.value())
101 connected_ = false; 101 connected_ = false;
102
103 // The remove device's bluetooth address may change if it is paired while
armansito 2015/09/23 06:46:59 nit: "The removed device's.."
sacomoto 2015/09/23 11:27:41 Done.
104 // connected.
105 if (property_name == properties->address.name())
106 device_address_ = properties->address.value();
armansito 2015/09/23 06:46:59 Won't you need to update the BluetoothDevice objec
sacomoto 2015/09/23 11:27:41 No. Only the DBus |object_path_| (not changed when
102 } 107 }
103 108
104 } // namespace chromeos 109 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698